Add ability to disable CDI hooks in jit-cdi mode#1859
Merged
Conversation
Coverage Report for CI Build 26549762496Coverage increased (+0.004%) to 43.5%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
cdesiniotis
commented
May 28, 2026
| // NVCDIFeatureFlags sets a list of nvcdi features explicitly. | ||
| NVCDIFeatureFlags []nvcdi.FeatureFlag `toml:"nvcdi-feature-flags,omitempty"` | ||
| // NVCDIDisableHooks sets a list of nvcdi hooks to disable | ||
| NVCDIDisabledHooks []nvcdi.HookName `toml:"nvcdi-disabled-hooks,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
Or should this be nvcdi-disable-hooks?
Contributor
Author
There was a problem hiding this comment.
I have updated this to nvcdi-disable-hooks to align the name here with the --disable-hooks flag for the nvidia-ctk cdi generate command.
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
5b33a55 to
cc8ae13
Compare
tariq1890
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nvcdi package has a disabledHooks option for disabling CDI hooks. The
nvidia-ctk cdi generateCLI exposes this option via a--disable-hooksflag.This PR adds the ability to disable CDI hooks in the CDI spec that gets generated by
nvidia-container-runtimewhen it runs injit-cdimode.Testing