Skip to content

Add ability to disable CDI hooks in jit-cdi mode #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdesiniotis merged 1 commit into from
May 28, 2026
+3 −0
Merged

Add ability to disable CDI hooks in jit-cdi mode #1859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/config/v1/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ type cdiModeConfig struct {
type jitCDIModeConfig struct {
// NVCDIFeatureFlags sets a list of nvcdi features explicitly.
NVCDIFeatureFlags []nvcdi.FeatureFlag `toml:"nvcdi-feature-flags,omitempty"`
// NVCDIDisableHooks sets a list of nvcdi hooks to disable
NVCDIDisableHooks []nvcdi.HookName `toml:"nvcdi-disable-hooks,omitempty"`
}

type csvModeConfig struct {
Expand Down
1 change: 1 addition & 0 deletions internal/modifier/cdi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ func (f *Factory) newAutomaticCDISpecModifier(devices []string) (oci.SpecModifie
nvcdi.WithFeatureFlags(f.cfg.NVIDIAContainerRuntimeConfig.Modes.JitCDI.NVCDIFeatureFlags...),
nvcdi.WithCSVCompatContainerRoot(f.cfg.NVIDIAContainerRuntimeConfig.Modes.CSV.CompatContainerRoot),
nvcdi.WithCSVFiles(csvFiles),
nvcdi.WithDisabledHooks(f.cfg.NVIDIAContainerRuntimeConfig.Modes.JitCDI.NVCDIDisableHooks...),
)
if err != nil {
return nil, fmt.Errorf("failed to construct CDI library for mode %q: %w", mode, err)
Expand Down
Loading