Seed the simulator RNG in test_multiple_shots to make it deterministic - #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_multiple_shotsintermittently fails its statistical 50/50 assertion (observed "got 70/30" on PR #453's unrelated CI run, ~8e-5 per-run odds on a fair coin at n=100). The test fixes the runner seed, but measurement outcomes draw from the simulator's own RNG, whichSparseStab::newseeds from entropy — so the outcomes were never deterministic.Fix: construct the simulator with
SparseStab::with_seed(1, 42). The test is now fully deterministic (verified identical results across repeated runs); the assertion itself is unchanged.Note for the RNG backlog (issue #332):
CircuitRunner::with_seednot governing measurement randomness is the underlying wart; this change makes the test honest without preempting the canonical RNG plumbing work.