Fix: Use valid SPDX license identifiers and add a NOTICE file - #95
Merged
Conversation
Member
Author
|
[written by AI] Targeting |
davetcoleman
marked this pull request as ready for review
September 2, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Problem
Every
package.xmlin this repo declared a license string that is not a valid SPDX identifier, so no automated tool can resolve what this code is licensed under. Seven packages saidApache2(SPDX isApache-2.0) and one saidBSD(ambiguous between 2-clause and 3-clause).Separately, the repo is Apache-2.0 but ships code from four distinct copyright holders with no
NOTICEfile recording them. Apache-2.0 section 4(d) is written around exactly that file.Changes
1. Valid SPDX identifiers.
Apache2becomesApache-2.0in seven packages, andBSDbecomesBSD-3-Clauseinabb_irb1200_5_90_moveit_config. No package's actual license changes, only the spelling of the identifier.2. A
NOTICEfile recording the four copyright holders whose code ships here, each with the license that applies and which files it covers. Sourced from the source-file headers, not assumed:abb_hardware_interface/src/utilities.cppand relatedabb_hardware_interface, modified by PickNik in 2022abb_irb1200_5_90_moveit_configTwo things deliberately left alone
abb_irb1200_5_90_moveit_configstays BSD-3-Clause, not Apache-2.0. An audit initially flagged it as conflicting with the repo's Apache-2.0 root. On inspection the mismatch is correct: it is an automatically generated ROS-Industrial MoveIt config authored by Andrew Short and maintained by Levi Armstrong at SwRI, and ROS-Industrial ships BSD-3-Clause. Forcing it to match the root would have relicensed someone else's code. TheNOTICEnow says so explicitly, so the next audit does not re-flag it.Likewise
abb_hardware_interfacekeeps bothApache-2.0andBSD-3-Clausetags. That dual declaration is right:abb_hardware_interface.cppis Apache-2.0 (ros2_control team, modified by PickNik) andutilities.cppis BSD-3-Clause (ABB Schweiz AG).The
LICENSEfile is untouched. Its appendix still carries the standard[yyyy] [name of copyright owner]placeholder, which is how the Apache-2.0 template ships. With four copyright holders, filling that in with a single name would overclaim. TheNOTICEis the correct place for that information and is what this PR adds.Scope
Eight
package.xmlfiles (one line each) plus a newNOTICE. No code, no build changes, no behavior change.<license>is manifest metadata that no build step consumes.Manual verification
None needed for the metadata. Reviewer sanity check worth doing: confirm the
NOTICEattributions match what you know of this repo's history, since it is the only file here making factual claims.Found during a licensing audit of all 109 PickNik-authored public repos. Tracked in PickNikRobotics/moveit_pro#22271.