chore: Update Sentry license attribution#647
Merged
Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
posthog/exception_utils.py:1-4
**Removal of specific source reference reduces attribution precision.** The old comment `# copied and adapted from https://github.com/getsentry/sentry-python/blob/269d96d6e9821122fbff280e6a26956e5ed03c0b/sentry_sdk/utils.py#L689` pointed to the exact commit and function that was adapted. The new header links only to the top-level license file, which is less useful for future maintainers who need to compare diffs or track upstream changes. Consider retaining the per-function source URL alongside the new license header.
### Issue 2 of 2
LICENSE:48
The file is missing a trailing newline after the final `SOFTWARE.` line — the diff shows `\ No newline at end of file`. Most POSIX tooling and text editors expect a newline at the end of text files; adding one here would keep the file consistent with the rest of the repository.
Reviews (1): Last reviewed commit: "chore: update sentry license attribution" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+1
to
4
| # Portions of this file are derived from getsentry/sentry-python | ||
| # Copyright (c) 2018 Functional Software, Inc. dba Sentry | ||
| # Licensed under the MIT License: https://github.com/getsentry/sentry-python/blob/master/LICENSE | ||
|
|
Contributor
There was a problem hiding this comment.
# copied and adapted from https://github.com/getsentry/sentry-python/blob/269d96d6e9821122fbff280e6a26956e5ed03c0b/sentry_sdk/utils.py#L689 pointed to the exact commit and function that was adapted. The new header links only to the top-level license file, which is less useful for future maintainers who need to compare diffs or track upstream changes. Consider retaining the per-function source URL alongside the new license header.
Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog/exception_utils.py
Line: 1-4
Comment:
**Removal of specific source reference reduces attribution precision.** The old comment `# copied and adapted from https://github.com/getsentry/sentry-python/blob/269d96d6e9821122fbff280e6a26956e5ed03c0b/sentry_sdk/utils.py#L689` pointed to the exact commit and function that was adapted. The new header links only to the top-level license file, which is less useful for future maintainers who need to compare diffs or track upstream changes. Consider retaining the per-function source URL alongside the new license header.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. | ||
| SOFTWARE. No newline at end of file |
Contributor
There was a problem hiding this comment.
SOFTWARE. line — the diff shows \ No newline at end of file. Most POSIX tooling and text editors expect a newline at the end of text files; adding one here would keep the file consistent with the rest of the repository.
Prompt To Fix With AI
This is a comment left during a code review.
Path: LICENSE
Line: 48
Comment:
The file is missing a trailing newline after the final `SOFTWARE.` line — the diff shows `\ No newline at end of file`. Most POSIX tooling and text editors expect a newline at the end of text files; adding one here would keep the file consistent with the rest of the repository.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
posthog-python Compliance ReportDate: 2026-06-03 19:52:34 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
marandaneto
changed the title
turnipdabeets
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Correct Sentry attribution in files that include code derived from getsentry/sentry-python and make the associated MIT license notice clearer.
💚 How did you test it?
Not run (license/comment-only change).
📝 Checklist
If releasing new changes
sampo addto generate a changeset file