Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,19 @@ SOFTWARE.

---

Some files in this codebase contain code from getsentry/sentry-python by Software, Inc. dba Sentry.
Some files in this codebase contain code from getsentry/sentry-python.
In such cases it is explicitly stated in the file header. This license only applies to the relevant code in such cases.

MIT License

Copyright (c) 2018 Functional Software, Inc. dba Sentry

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
of the Software, and to permit persons to whom the Software is furnished to do
so, subject to the following conditions:
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
Expand All @@ -45,4 +45,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
SOFTWARE.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The file is missing a trailing newline after the final SOFTWARE. line — the diff shows \ No newline at end of file. Most POSIX tooling and text editors expect a newline at the end of text files; adding one here would keep the file consistent with the rest of the repository.

Prompt To Fix With AI
This is a comment left during a code review.
Path: LICENSE
Line: 48

Comment:
The file is missing a trailing newline after the final `SOFTWARE.` line — the diff shows `\ No newline at end of file`. Most POSIX tooling and text editors expect a newline at the end of text files; adding one here would keep the file consistent with the rest of the repository.

How can I resolve this? If you propose a fix, please make it concise.

5 changes: 3 additions & 2 deletions posthog/exception_capture.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Portions of this file are derived from getsentry/sentry-python by Software, Inc. dba Sentry
# Licensed under the MIT License
# Portions of this file are derived from getsentry/sentry-python
# Copyright (c) 2018 Functional Software, Inc. dba Sentry
# Licensed under the MIT License: https://github.com/getsentry/sentry-python/blob/master/LICENSE

# 💖open source (under MIT License)

Expand Down
6 changes: 3 additions & 3 deletions posthog/exception_utils.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Portions of this file are derived from getsentry/sentry-python by Software, Inc. dba Sentry
# Licensed under the MIT License
# Portions of this file are derived from getsentry/sentry-python
# Copyright (c) 2018 Functional Software, Inc. dba Sentry
# Licensed under the MIT License: https://github.com/getsentry/sentry-python/blob/master/LICENSE

Comment on lines +1 to 4
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Removal of specific source reference reduces attribution precision. The old comment # copied and adapted from https://github.com/getsentry/sentry-python/blob/269d96d6e9821122fbff280e6a26956e5ed03c0b/sentry_sdk/utils.py#L689 pointed to the exact commit and function that was adapted. The new header links only to the top-level license file, which is less useful for future maintainers who need to compare diffs or track upstream changes. Consider retaining the per-function source URL alongside the new license header.

Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog/exception_utils.py
Line: 1-4

Comment:
**Removal of specific source reference reduces attribution precision.** The old comment `# copied and adapted from https://github.com/getsentry/sentry-python/blob/269d96d6e9821122fbff280e6a26956e5ed03c0b/sentry_sdk/utils.py#L689` pointed to the exact commit and function that was adapted. The new header links only to the top-level license file, which is less useful for future maintainers who need to compare diffs or track upstream changes. Consider retaining the per-function source URL alongside the new license header.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

# copied and adapted from https://github.com/getsentry/sentry-python/blob/269d96d6e9821122fbff280e6a26956e5ed03c0b/sentry_sdk/utils.py#L689
# 💖open source (under MIT License)
# We want to keep payloads as similar to Sentry as possible for easy interoperability

Expand Down
Loading