-
Notifications
You must be signed in to change notification settings - Fork 70
chore: Update Sentry license attribution #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # Portions of this file are derived from getsentry/sentry-python by Software, Inc. dba Sentry | ||
| # Licensed under the MIT License | ||
| # Portions of this file are derived from getsentry/sentry-python | ||
| # Copyright (c) 2018 Functional Software, Inc. dba Sentry | ||
| # Licensed under the MIT License: https://github.com/getsentry/sentry-python/blob/master/LICENSE | ||
|
|
||
|
Comment on lines
+1
to
4
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Prompt To Fix With AIThis is a comment left during a code review.
Path: posthog/exception_utils.py
Line: 1-4
Comment:
**Removal of specific source reference reduces attribution precision.** The old comment `# copied and adapted from https://github.com/getsentry/sentry-python/blob/269d96d6e9821122fbff280e6a26956e5ed03c0b/sentry_sdk/utils.py#L689` pointed to the exact commit and function that was adapted. The new header links only to the top-level license file, which is less useful for future maintainers who need to compare diffs or track upstream changes. Consider retaining the per-function source URL alongside the new license header.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| # copied and adapted from https://github.com/getsentry/sentry-python/blob/269d96d6e9821122fbff280e6a26956e5ed03c0b/sentry_sdk/utils.py#L689 | ||
| # 💖open source (under MIT License) | ||
| # We want to keep payloads as similar to Sentry as possible for easy interoperability | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SOFTWARE.line — the diff shows\ No newline at end of file. Most POSIX tooling and text editors expect a newline at the end of text files; adding one here would keep the file consistent with the rest of the repository.Prompt To Fix With AI