test: isolate credential vaults - #293
Draft
mark-e-deyoung wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #292.
What changed
Root cause
force_dpapi()selected the file backend but retained the production%APPDATA%\WinInspect\credentials.vaultpath. Tests therefore depended on external user state and could fail under constrained CTest environments.Validation
test_core: 10 consecutive CTest runs passedbuild/test-tmp--Werrorgit diff --checkFormal-method assessment
No TLA+ update is needed: this patch changes dependency injection for storage location and does not alter a modeled protocol or state transition. Existing formal trace replay remains part of
test_coreand passes.Follow-up discovered during clean validation
A fresh MSVC configure does not supply
/EHscin this environment; with/WX, C4530 fails the build. Validation used the previously required explicit MSVC flags. That build-system defect will be handled in a separate focused issue/PR.