feat(tv): improve Shield setup, controls, and subtitle switching - #159
Merged
RXWatcher merged 29 commits intoAug 2, 2026
Merged
Conversation
2 tasks
|
Warning Review limit reached
Next review available in: 38 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesThe PR adds external subtitle sidecar negotiation and mounting for local Media3 playback, with Cast exclusion and protocol compatibility coverage. It adds fixed TV subtitle sizing, shared Android TV IME-aware form scrolling, responsive login match-code sizing, subtitle-picker exit handling, transport accessibility updates, and mounted-sidecar transaction coverage. Playback subtitle capabilities
Android TV IME-aware forms
Android TV player interactions
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@androidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/auth/TvServerSetupScreen.kt`:
- Around line 405-463: The ManualEntryCard layout currently inherits the fixed
SERVER_SETUP_CHOOSER_HEIGHT and cannot expand for validation or
cleartext-warning content. Update the chooser/card sizing around ManualEntryCard
to use that value as a minimum height rather than a fixed height, allowing the
card to grow while preserving the existing baseline size and outer scrolling
behavior.
In
`@androidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerRemoteKeyAction.kt`:
- Around line 35-38: Update the KEYCODE_DPAD_DOWN branch in
TvPlayerRemoteKeyAction so it returns FocusTransport only for the initial
ACTION_DOWN event, consumes repeated ACTION_DOWN events without remapping focus,
and preserves the existing non-down behavior. Match the established media
Left/Right handling pattern and add a regression test asserting repeatCount = 1
is consumed without returning FocusTransport.
In
`@docs/superpowers/specs/2026-08-02-tv-player-transport-accessibility-design.md`:
- Around line 31-33: Update the transport-dimensions boundary description in the
design document to identify TvPlayerTransportVisualPolicy.kt as the
centralization point, with TvPlayerTransportCluster.kt consuming that policy.
Leave the hidden-overlay key mapping and all HUD, subtitle, and player-state
requirements unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 589d8a60-60cd-4e1a-be44-ced555e8c963
📒 Files selected for processing (42)
android-shared/src/androidMain/kotlin/org/siloserver/silo/common/player/AndroidSubtitleTextSizePolicy.ktandroid-shared/src/androidMain/kotlin/org/siloserver/silo/common/player/PlaybackCapabilityDetector.ktandroid-shared/src/androidMain/kotlin/org/siloserver/silo/common/player/PlaybackSessionManager.ktandroid-shared/src/androidMain/kotlin/org/siloserver/silo/common/player/PlaybackV3Session.ktandroid-shared/src/androidMain/kotlin/org/siloserver/silo/common/player/SubtitleManager.ktandroid-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/player/AndroidSubtitleTextSizePolicyTest.ktandroid-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/player/PlaybackSessionManagerSeekReanchorTest.ktandroid-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/player/PlaybackV3SessionTest.ktandroid-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/player/SubtitleManagerAppearanceTest.ktandroid-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/player/cast/CastPlaybackPreparerTest.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/components/TvImeAwareForm.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/components/TvTextInputDialog.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/auth/TvLoginScreen.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/auth/TvServerSetupScreen.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/auth/TvSetupScreen.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/auth/TvSignupScreen.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerRemoteKeyAction.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerScreen.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerTransportCluster.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerTransportVisualPolicy.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvQuickSubtitlePickerChromePolicy.ktandroidTvApp/src/androidMain/kotlin/org/siloserver/silo/tv/ui/screens/player/TvSubtitleTransactionAdapter.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/components/TvImeAwareFormTest.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/screens/auth/TvLoginMatchCodeLayoutTest.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/screens/player/SubtitleTransactionIntegrationTest.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerRemoteKeyActionTest.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/screens/player/TvPlayerTransportVisualPolicyTest.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/screens/player/TvQuickSubtitlePickerChromePolicyTest.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/screens/player/TvSubtitleFinalRollbackTest.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/screens/player/TvSubtitleSettlementOwnershipTest.ktandroidTvApp/src/androidUnitTest/kotlin/org/siloserver/silo/tv/ui/screens/player/TvSubtitleTransactionAdapterTest.ktdocs/superpowers/plans/2026-08-02-android-tv-auth-ime-relocation.mddocs/superpowers/plans/2026-08-02-instant-external-srt-switching-android.mddocs/superpowers/plans/2026-08-02-tv-mounted-srt-fast-switch.mddocs/superpowers/plans/2026-08-02-tv-player-transport-accessibility.mddocs/superpowers/plans/2026-08-02-tv-subtitle-picker-and-sizing.mddocs/superpowers/specs/2026-08-02-android-tv-auth-ime-relocation-design.mddocs/superpowers/specs/2026-08-02-tv-mounted-srt-fast-switch-design.mddocs/superpowers/specs/2026-08-02-tv-player-transport-accessibility-design.mddocs/superpowers/specs/2026-08-02-tv-subtitle-picker-and-sizing-design.mdshared/src/commonMain/kotlin/org/siloserver/silo/model/playback/PlaybackProtocolV3.ktshared/src/commonTest/kotlin/org/siloserver/silo/model/playback/PlaybackProtocolV3Test.kt
💤 Files with no reviewable changes (1)
- android-shared/src/androidUnitTest/kotlin/org/siloserver/silo/common/player/SubtitleManagerAppearanceTest.kt
This was referenced Aug 3, 2026
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the Android TV/Shield setup and playback experience, culminating in instant switching between negotiated external SRT/VTT subtitles.
Companion server PR: Silo-Server/silo-server#532
What changed
Compatibility
The Android build works unchanged without server PR #532. If
sidecarsis absent, it decodes as an empty list and uses the existing subtitle artifact/replan flow. Instant switching activates only when the updated server explicitly negotiates the feature.Testing
./gradlew test— PASS (257 actionable tasks)./gradlew :androidTvApp:assembleDebug— PASSgit diff --check— PASSversionCode=15), manually reviewed, then force-stopped; it was not launched after the final installAI disclosure
Summary by CodeRabbit
New Features
Bug Fixes