Skip to content

fix(playback): honor source color range fallback - #86

Draft
Quick104 wants to merge 1 commit into
mainfrom
codex/native-color-range
Draft

fix(playback): honor source color range fallback#86
Quick104 wants to merge 1 commit into
mainfrom
codex/native-color-range

Conversation

@Quick104

Copy link
Copy Markdown
Contributor

Summary

  • decode color_range from catalog metadata and the additive playback-v3 source descriptor
  • carry the range through phone and TV playback media specs
  • map FFmpeg tv to Media3 limited range and pc to full range only when extractor color range is unspecified
  • compose the fallback with existing HLG and Dolby Vision corrections instead of replacing them

Why

Silo preserves direct-play bytes, but Media3 can receive an unspecified container range. The server-probed FFmpeg value supplies a safe fallback while explicit extractor metadata remains authoritative.

Testing

  • focused shared and android-shared unit tests for catalog/v3 serialization, session conversion, and limited/full/conflict/unknown mappings
  • :androidApp:compileDebugKotlinAndroid
  • :androidTvApp:compileDebugKotlinAndroid
  • autoreview clean

Coordination

Depends on Silo-Server/silo-server#447.

Part of Silo-Server/silo-server#446

AI use

Implemented with OpenAI Codex. The generated patch was reviewed, focused tests and both client compiles were run, and review findings were addressed before publication.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 39d60797-01da-4706-a7b2-87f7d97e2c41

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/native-color-range

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant