This repository was archived by the owner on Aug 5, 2026. It is now read-only.
fix: upgrade tsconfig target from ES5 to ES2017 for TypeScript 6 compatibility - #4677
Closed
GC Zhu (gc-skyscanner) wants to merge 2 commits into
Closed
fix: upgrade tsconfig target from ES5 to ES2017 for TypeScript 6 compatibility#4677GC Zhu (gc-skyscanner) wants to merge 2 commits into
GC Zhu (gc-skyscanner) wants to merge 2 commits into
Conversation
…atibility TypeScript 6.0 deprecated target=ES5 (error TS5107). All supported browsers (Chrome 109+, Edge 142+, Firefox 145+, Safari 16+) fully support ES2017. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Visit https://backpack.github.io/storybook-prs/4677 to see this build running in a browser. |
ES2022 is fully supported by all browserslist targets (Chrome 109+, Safari 16+). More accurate than ES2017 for type-checking built-in APIs, and safer than ES2025 which has features not supported by Safari 16. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Visit https://backpack.github.io/storybook-prs/4677 to see this build running in a browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI failure in #4445 (Dependabot bump of TypeScript 5.9.3 → 6.0.3).
Root cause
TypeScript 6.0 deprecated
target=ES5(errorTS5107) and the build fails with:Fix
Updated
targetfromES5toES2017in:tsconfig.base.jsontsconfig.declaration.jsonWhy ES2017?
All supported browser targets (Chrome 109+, Edge 142+, Firefox 145+, Safari 16+, Samsung 29+) fully support ES2017. There's no reason to compile down to ES5. ES2017 preserves async/await syntax and modern class fields natively.
🤖 Generated with Claude Code