Add Template Command Stuyle Robot Project for 2027 - #9
Merged
Conversation
hc-45
marked this pull request as draft
July 29, 2026 19:00
hc-45
marked this pull request as ready for review
July 29, 2026 19:14
Danx3mer
requested changes
Jul 31, 2026
Danx3mer
left a comment
Danx3mer
left a comment
Contributor
There was a problem hiding this comment.
Overall pretty good, please read my review comments and make the requested changes or explain why you changed the things I asked about
Contributor
There was a problem hiding this comment.
Is there a reason why this was changed to be a class instead of an interface?
| * | ||
| * We use DogLog's tunables in order to have tunable | ||
| * values that we can edit on Shuffleboard. | ||
| * <p>We use DogLog's tunables in order to have tunable values that we can edit from external |
| /** | ||
| * | ||
| * | ||
| * <h2>Robot Class</h2> |
Contributor
There was a problem hiding this comment.
Please remove h2 tag and all the extra newlines commented out
| public final CommandXboxController driver = new CommandXboxController(Ports.Gamepad.DRIVER); | ||
| public final CommandXboxController operator = new CommandXboxController(Ports.Gamepad.OPERATOR); | ||
|
|
||
| public final CommandNiDsXboxController driver = |
Contributor
There was a problem hiding this comment.
Is there a reason for changing the type of these variables?
Member
Author
There was a problem hiding this comment.
the old type doesn't exist anymore as far as i know
Contributor
There was a problem hiding this comment.
Please remove this file and replace it with a new file with nothing in it by the name of ".gitkeep"
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2024 StuyPulse | |||
…L tags in javadoc comments, change Ports class to interface
Danx3mer
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.