Skip to content

feat(api): add shared confirmation number and property date helpers - #351

Merged
telivity-otaip merged 5 commits into
mainfrom
cursor/core-booking-utils-4a4f
Aug 27, 2026
Merged

feat(api): add shared confirmation number and property date helpers#351
telivity-otaip merged 5 commits into
mainfrom
cursor/core-booking-utils-4a4f

Conversation

@telivity-otaip

@telivity-otaip telivity-otaip commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Shared prerequisite utilities for confirmation codes, property calendar dates, and money-string validation — used by booking-requests and other modules.

Changes

  • generateConfirmationNumber() — cryptographically random guest-facing bearer codes (128-bit entropy via randomBytes; injectable entropy seam for tests)
  • generateConfirmationToken() — Crockford base32 suffix (no HAIP- prefix) for connect/channel prefixes
  • calendarDateInTimeZone() — property calendar date without server-UTC leakage; invalid IANA zones fall back to UTC
  • IsMoneyString validator — optional maximum inclusive bound; tests for boundary accept/reject
  • Caller migration: connect-booking.service generateConfirmationToken() now routes through the shared helper (single implementation)

Tests

  • confirmation-number.spec.ts — entropy seam + format
  • property-business-date.spec.ts — UTC/Eastern boundary + invalid timezone fallback
  • is-money-string.validator.spec.ts — maximum inclusive boundary

How to test

pnpm --filter @telivityhaip/api test -- src/common/crypto/confirmation-number.spec.ts src/common/date/property-business-date.spec.ts src/common/validation/is-money-string.validator.spec.ts
pnpm --filter @telivityhaip/api test -- src/modules/connect/confirmation-token.spec.ts

Contributor credit

@agustinjch

@cursoragent @agustinjch
feat(api): add shared confirmation number and property date helpers
f99ccb7 
Add confirmation-number crypto helper, property-business-date utility,
and tighten is-money-string validation for decimal amounts.

Co-authored-by: Agus <agustin.jch@gmail.com>
cursor Bot pushed a commit that referenced this pull request Aug 26, 2026
@cursoragent @telivity-otaip
refactor(booking-requests): slim package PR to booking-requests scope
827df43 
Remove email transport, webhook dedup, shared utils, test-count sync, and
core webhook migration changes that land in separate focused PRs. Document
booking-requests in README packages section and optional enablement steps.

Depends on #349, #350, #351, #352, and #353.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
This was referenced Aug 26, 2026
Merged
Closed
@cursoragent @telivity-otaip
chore: sync README test counts for CI
e7a6019 
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
@agustinjch

agustinjch commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

This is a useful small prerequisite. I checked e7a6019; API typecheck and the focused confirmation-number test pass.

Before merge, I would tighten up the following:

  1. Two of the three advertised behaviors have no direct tests. Please add coverage for calendarDateInTimeZone() at a UTC/property-date boundary plus invalid-timezone fallback, and for the money maximum option accepting the exact boundary and rejecting a value above it. The repository requires tests for new business logic.
  2. “Deterministic guest-facing confirmation codes” is misleading: the default implementation intentionally uses randomBytes. I suggest “cryptographically random guest-facing confirmation codes”; the injected entropy seam is what makes the unit test deterministic.
  3. At this PR head the new confirmation/date helpers sit alongside existing implementations and are not consumed yet. That is acceptable if this is explicitly a prerequisite for feat(booking-requests): add optional booking-requests module #348, but ideally migrate the existing callers here so there is only one implementation to maintain.

No raw SQL, tenant, financial, or dependency concerns in this diff. With the missing tests and wording corrected, this should be straightforward to approve.

@agustinjch agustinjch mentioned this pull request Aug 26, 2026
Merged
@cursoragent @telivity-otaip
fix(utils): address #351 review — tests, wording, unify confirmation …
0bb6a4b 
…token

Add property-business-date and money maximum tests. Clarify that
confirmation codes are cryptographically random. Route connect
generateConfirmationToken through the shared helper.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Aug 27, 2026
@cursoragent @telivity-otaip
merge: #351 utils into readme sync branch
13eab73 
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Aug 27, 2026
@cursoragent @telivity-otaip
fix(readme): regenerate counts after #349+#351 merge (1596/225)
fc05d13 
Split Testing/Build table rows and normalize legacy concatenated rows in
sync-test-count.mjs per review.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
@telivity-otaip
telivity-otaip marked this pull request as ready for review August 27, 2026 01:55
@telivity-otaip

telivity-otaip commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the review — all three points addressed on 0bb6a4b (current head).

1. Missing tests

  • property-business-date.spec.ts — UTC vs America/New_York midnight boundary + invalid timezone → UTC fallback
  • is-money-string.validator.spec.ts — maximum accepts inclusive boundary, rejects above

2. Wording
Comment/spec now say cryptographically random (default randomBytes; injectable entropy seam for deterministic unit tests).

3. Caller migration
connect-booking.service generateConfirmationToken() routes through the shared confirmation-number helper — single Crockford implementation.

PR description updated. Ready for your re-review.

cursoragent and others added 2 commits August 27, 2026 02:21
@cursoragent
merge(main): resolve README test-count conflicts for PR #351
fb864d3 
Merged origin/main into cursor/core-booking-utils-4a4f. Only conflict
was README.md test count badges (simple). Took main baseline, regenerated
counts via scripts/sync-test-count.mjs. Brings in room-type update from
#354. Focused booking-utils specs pass.
@cursoragent @telivity-otaip
Merge origin/main into cursor/core-booking-utils-4a4f
4e72f57 
Resolve README/test-stats conflicts after #349/#350 merges; sync counts.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
@telivity-otaip
telivity-otaip merged commit 75a8fc9 into main Aug 27, 2026
5 checks passed
cursor Bot pushed a commit that referenced this pull request Aug 27, 2026
@cursoragent @telivity-otaip
fix(readme): full applyCounts --check and rebase on main
9c7ce6d 
--check now compares the entire README to applyCounts output so badge,
heading, command count, and malformed-row normalization cannot go stale
while CI still passes. Adds regression coverage for each managed site.

Rebuilt on current main (#349/#350/#351), regenerated counts: 1630/228.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip added a commit that referenced this pull request Aug 27, 2026
@telivity-otaip @cursoragent
fix(readme): full applyCounts --check and rebase on main (#352)
387d149 
--check now compares the entire README to applyCounts output so badge,
heading, command count, and malformed-row normalization cannot go stale
while CI still passes. Adds regression coverage for each managed site.

Rebuilt on current main (#349/#350/#351), regenerated counts: 1630/228.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip added a commit that referenced this pull request Aug 28, 2026
@telivity-otaip
feat(booking-requests): add optional booking-requests module (#348)
ee36db0 
* Add opt-in booking-requests package with core seams and UI gates

Introduce @telivityhaip/booking-requests as a deploy-time optional module
(HAIP_BOOKING_REQUESTS=true) with separate migrations, Stripe handler
delegation, and dashboard/booking widget feature flags. Core instant booking
paths stay unchanged when the flag is off.

Includes booking request API/controllers, schema split (0022-0032), email
transport hardening, webhook logicalEventId dedup, and CI release-gate job.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* refactor(booking-requests): slim package PR to booking-requests scope

Remove email transport, webhook dedup, shared utils, test-count sync, and
core webhook migration changes that land in separate focused PRs. Document
booking-requests in README packages section and optional enablement steps.

Depends on #349, #350, #351, #352, and #353.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(ci): restore core seams, push-schema columns, and README test counts

Re-include prerequisite core changes so typecheck and docker seed pass.
Add booking-requests to CI/Docker builds. Sync README to 2120 tests / 252 files.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(ci): add charge amendment columns to push-schema and webhook spec

push-schema now creates adjusts_charge_id and source_key so seed and
docker init succeed. Webhook logicalEventId spec uses reservation.created
from the core WEBHOOK_EVENTS catalog.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(docker): lazy-load booking-requests only when feature flag is on

Static imports pulled @telivityhaip/booking-requests into the default demo
image and crashed startup with missing @nestjs/common. Gate the optional
package behind HAIP_BOOKING_REQUESTS and read the flag from core seams.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(docker): preload optional booking-requests modules async

Avoid loading @telivityhaip/booking-requests at startup when
HAIP_BOOKING_REQUESTS is off (docker demo). Preload before Nest bootstrap
when the flag is enabled; read the flag from core payment seams in
DatabaseModule.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(api): type bootstrap cache as DynamicModule array

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(booking-requests): address Agustin packaging/safety review

- Ship runnable migrator + SQL in dist; production db:migrate via node
- Wire VITE_HAIP_BOOKING_REQUESTS through Docker/compose/release
- Reject bookingMode=request when HAIP_BOOKING_REQUESTS is off
- Ledger + checksum for package migrations (auto-commit for PG enums)
- Drop unused stripeHandlerToken from root module options
- Fix EmailResult outcomeUnknown after #349 status contract
- Point regression/e2e installs at run-migrations.js (post-#350)
- Harden push-schema CLI path resolution; sync README (2175/259)

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(database): keep logical_event_id out of push-schema baseline

#350 moved webhook logical_event_id to migration 0022. Remove the column
and unique index from push-schema so the pre-0022 upgrade regression
passes again.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* chore: sync README test counts to 2180/260

Matches CI after push-schema logical_event_id cleanup (all packages green).

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* test(booking-requests): flag-off regression gate + port PR #347 safety specs

- Add a flag-OFF default-install regression spec: only core migrations run,
  HAIP_BOOKING_REQUESTS is unset, AppModule boots without the
  booking-requests module/tables, request mode is rejected, and instant
  booking + deposit capture + partial/full refund still work. Runs
  automatically under `pnpm test` (apps/api's normal *.spec.ts glob), so it
  is wired into CI without any workflow changes.
- Extract the ephemeral-database subprocess helpers shared by that spec and
  the existing default-flow regression spec into
  regression-database-utils.ts (createdb/dropdb, sanitized child-process
  errors) instead of duplicating them.
- Port PR #347's booking-request-schema.spec.ts and
  booking-request-migration-safety.spec.ts into the package, scoped to the
  tables/migrations this package now owns (the duplicate push-schema DDL
  those specs cross-checked no longer exists — it moved into this package's
  migrations).
- Port PR #347's booking-request-remediation.postgres.spec.ts, replaying
  migration 0032's SQL directly (instead of through push-schema) since the
  ledger-based migrator can't be re-run against a manually-reverted schema.
  Kept opt-in via BOOKING_REQUEST_REMEDIATION_LIVE_PG like the original.
- Document remaining scope (vertical-slice move, push-schema de-pollution)
  in the package README instead of attempting it in this pass.
- Sync README/test-stats test counts (2211 tests, 263 files).

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* feat(booking-requests): package-owned port for booking_mode/payment_method_collection/form_questions

Adds BOOKING_REQUEST_CONFIG_FIELDS_PORT + DrizzleBookingRequestConfigFieldsAdapter
so the package owns reading/writing booking_engine_config's request-mode-only
columns via its own Drizzle table fragment, instead of core declaring them.
Wired into BookingRequestModule.forRoot() (global) so it's injectable into
core's BookingEngineConfigService without that module importing this package.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* chore(database): remove request-only DDL from core push-schema/drizzle

Removes booking_mode/payment_method_collection/form_questions ALTERs on
booking_engine_config, audit_logs.booking_request_id (+ its timeline index),
and the request-shape unique indexes/checks on payments
(payments_property_request_*_unique, booking_request_parent_positive_check,
booking_request_child_shape_check) from core's push-schema.ts and Drizzle
schema. These are now declared and migrated exclusively by
packages/booking-requests. payments.booking_request_id/idempotency_key,
reservations.accepted_pricing_snapshot, and charges
adjusts_charge_id/source_key stay in core as documented in
push-schema-kept-fields.spec.ts.

Also adds the DRIZZLE injection token to @telivityhaip/database so packages
outside apps/api (booking-requests) can inject the shared Drizzle client
without importing apps/api.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* refactor(booking-requests): move Nest vertical slice into package

Own controllers/services/DTOs behind package ports; strip request-only
audit DDL and payment indexes from core schema; keep thin config/payment hooks.

- Nest controllers, DTOs, services, Stripe handler, and pricing/money/
  state/db/ledger/reconciler/template helpers now live in
  packages/booking-requests/src (http/ + domain/), with their unit specs.
  BookingRequestModule.forRoot(...) is a real DynamicModule owning those
  controllers/providers directly, not a facade over apps/api classes.
- apps/api/src/modules/booking-request/ keeps only the e2e, authorization,
  default-flow-regression, flag-off-instant-booking.regression, and
  transaction-seams specs plus regression-database-utils.ts.
- apps/api/src/booking-requests.bootstrap.ts wires every package-local port
  (folio, webhook, email, reservation, rate-plan, guest, ancillary,
  availability, booking-engine, booking-engine-config, plus guard-bridge
  ports) to the concrete core singleton via `useExisting`.
- Guard bridge classes (BookingKeyGuardBridge, BookingEngineScopeGuardBridge,
  BookingThrottleGuardBridge) resolve the "guards landmine": @UseGuards(...)
  is populated from decorator metadata, a separate path from `providers`, so
  a bare useExisting binding on an abstract port class is silently dropped —
  the bridges are real injectable classes referenced in @UseGuards(...).
- DRIZZLE token declaration moved to @telivityhaip/database; apps/api's
  DatabaseModule still @Global-provides it and merges in the package's
  optional schema only when HAIP_BOOKING_REQUESTS is on.
- Relocated pure/shared pieces to packages/shared: SAVED_PAYMENT_METHOD_GATEWAY
  / PAYMENT_GATEWAY / BOOKING_REQUEST_STRIPE_HANDLER interfaces, IsMoneyString,
  canonical calendar date validators, stayDates, AuditActor helpers,
  RequirePermissions/Public decorators, stripe-financial-state helpers, and
  the pure payment-ledger math (remainingCapturedAmount/sumRefundChildren) —
  bookingRequestPaymentSumWhere stays in core payment-ledger.
- Schema de-pollution: removed audit_logs.booking_request_id (+ its timeline
  index) and the request-shape payments unique indexes/checks from core
  push-schema/drizzle; kept booking_engine_config.booking_mode /
  payment_method_collection / form_questions, payments.booking_request_id /
  idempotency_key, reservations.accepted_pricing_snapshot, and charges
  adjusts_charge_id/source_key as thin config/payment hooks core still reads
  directly. packages/database/src/push-schema-kept-fields.spec.ts guards the
  contract; packages/booking-requests declares its own local audit table
  extension for the timeline index it still owns.
- EventEmitterModule.forRoot() re-enabled `wildcard: true` — required for the
  webhook fan-out (@onevent('**')) to receive booking-request events.
- README's "Package boundary" section replaces the old "Remaining work"
  deferrals list with an accurate description of the current split.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(docker): ship shared node_modules for Nest peer in prod image

Shared now requires @nestjs/common at runtime after the booking-requests
boundary move; copy packages/shared/node_modules into the API image so
demo smoke can boot. Sync published test counts to 2222/266.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>

* fix(api): load AppModule after booking-requests preload

When HAIP_BOOKING_REQUESTS=true, AppModule evaluates bookingRequestsModules()
at import time; dynamic-import AppModule after preload so flag-on dev/prod
boot does not crash before Nest starts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agustinjch agustinjch Awaiting requested review from agustinjch

Assignees

@agustinjch agustinjch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@telivity-otaip @agustinjch @cursoragent