unify(client): Move Main Menus and Shell callbacks to Core

[DevGeniusCode]

Dependency Note:
This PR is built on top of PR #2620 . The diff currently includes files from previous PRs. Once PR #2620 is merged into upstream main, this PR will automatically update to show only the relevant changes.

Summary

Continuing the effort to unify the GameClient components by migrating the core Main Menus, Options, and Shell callbacks from GeneralsMD directly to the Core structure.

Key Changes

• File Relocation: Moved 13 GameClient files related to main game menus and shell systems to Core.
• Functional Parity: The logic across all moved files remains strictly intact and functionally identical between Vanilla and Zero Hour.

Files Moved:

Main & Option Menus:

• SinglePlayerMenu.cpp
• CreditsMenu.cpp
• DifficultySelect.cpp
• DownloadMenu.cpp
• KeyboardOptionsMenu.cpp
• QuitMenu.cpp

Replay Menus & Controls:

• ReplayMenu.cpp
• PopupReplay.cpp
• ReplayControls.cpp

Shell Systems:

• ShellMenuScheme.cpp / ShellMenuScheme.h
• Shell.h
• ShellHooks.h

[greptile-apps]

Greptile Summary

This PR continues the GameClient unification effort by migrating 13 files (main menus, shell systems, replay controls) from GeneralsMD to Core, with corresponding CMakeLists.txt entries commented out in both Generals/Code and GeneralsMD/Code and uncommented in Core. The logic in all moved files is preserved verbatim — no functional changes are introduced.

Confidence Score: 5/5

Safe to merge — pure file relocation with no logic changes and consistent CMake updates across all three targets.

All 13 moved files retain their original content exactly. CMakeLists.txt is correctly updated in Core (uncommented), Generals (commented), and GeneralsMD (commented). Headers use #pragma once, GPL headers are present, and no NULL pointer literals were introduced. The Python migration script has the new operations recorded as comments in main() per the established pattern.

No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/CMakeLists.txt	Uncommented 13 new entries (Shell.h, ShellHooks.h, ShellMenuScheme.h/.cpp, and 9 menu .cpp files); Shell.cpp correctly remains commented out as it stays game-specific.
Generals/Code/GameEngine/CMakeLists.txt	Shell.h, ShellHooks.h, ShellMenuScheme.h, ShellMenuScheme.cpp, and 9 menu .cpp files correctly commented out; Shell.cpp kept active as Generals-specific implementation.
GeneralsMD/Code/GameEngine/CMakeLists.txt	Matching entries commented out (Shell.h, ShellHooks.h, ShellMenuScheme.h/.cpp, 9 menu files); Shell.cpp kept active for Zero Hour.
Core/GameEngine/Include/GameClient/Shell.h	Moved from GeneralsMD to Core intact; uses #pragma once, GPL header present, class interface unchanged.
Core/GameEngine/Include/GameClient/ShellHooks.h	Moved from GeneralsMD to Core intact; uses #pragma once, shell hook enum and SignalUIInteraction declaration preserved.
Core/GameEngine/Include/GameClient/ShellMenuScheme.h	Moved from GeneralsMD to Core; uses #pragma once, full class hierarchy for ShellMenuSchemeLine/Image/Scheme/Manager preserved.
Core/GameEngine/Source/GameClient/GUI/Shell/ShellMenuScheme.cpp	Implementation moved from GeneralsMD to Core; GPL header present, no NULL pointer usage, logic unchanged.
scripts/cpp/unify_move_files.py	Added 13 new commented-out unify_file() calls in main() documenting the operations performed by this PR; script logic unchanged.
Core/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/SinglePlayerMenu.cpp	Moved from GeneralsMD to Core verbatim; GPL header present, no pointer-related changes.
Core/GameEngine/Source/GameClient/GUI/GUICallbacks/ReplayControls.cpp	Moved from GeneralsMD to Core verbatim; no NULL pointer usage found, GPL header intact.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["Before This PR"]
        G["Generals/Code/GameEngine\n(Shell.h, ShellHooks.h, ShellMenuScheme.h\nShellMenuScheme.cpp, 9 menu .cpp files)"]
        ZH["GeneralsMD/Code/GameEngine\n(Same 13 files — duplicate)"]
    end

    subgraph After["After This PR"]
        C["Core/GameEngine\n(Shell.h, ShellHooks.h, ShellMenuScheme.h\nShellMenuScheme.cpp, 9 menu .cpp files)"]
        GS["Generals/Code/GameEngine\nShell.cpp (game-specific, kept)"]
        ZHS["GeneralsMD/Code/GameEngine\nShell.cpp (game-specific, kept)"]
        GS -->|"#includes Core headers"| C
        ZHS -->|"#includes Core headers"| C
    end

    G -->|"deleted"| C
    ZH -->|"deleted"| C

Loading

_{Reviews (3): Last reviewed commit: "unify(client): Move Main Menus and Shell..." | Re-trigger Greptile}

[Skyaero42]

This is a merge and move. Files first need to be merged in one PR and then moved in another PR to allow for proper reviewing.

[DevGeniusCode]

This is a merge

Which file are not same? (without spelling errors)