bugfix(watertracks): Correct the path handling for .wak files in the WaterTracksRenderSystem

[Mauller]

Closes: #2633

Merge After: #2635

This fixes a file loading issue which was introduced by a regression in #1808

The functionality that was overlooked was the original code truncating the .map extension from the file name.

We now use the AsciiString::truncateBy() AsciiString::removeExtensions() TheFileSystem::removeExtension() function to remove the .map extension before copying the ascii string.

[greptile-apps]

Greptile Summary

This PR fixes a regression from #1808 in WaterTracksRenderSystem::saveTracks() and loadTracks(), where the old code appended .wak directly onto the full filename (producing mapname.map.wak) instead of first stripping the .map extension. The fix replaces the fixed 256-byte char buffer + strlcpy/strlcat pattern with FileSystem::removeExtension(fileName) followed by fileName.concat(".wak"), which correctly yields mapname.wak.

Confidence Score: 5/5

Safe to merge — the fix is correct, consistent across both call sites, and eliminates a buffer-size risk.

No P0 or P1 findings. The static FileSystem::removeExtension correctly strips the dot-extension via pointer arithmetic before the new extension is appended, and this pattern is applied identically in both saveTracks and loadTracks.

No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngineDevice/Source/W3DDevice/GameClient/Water/W3DWaterTracks.cpp	Correctly replaces fixed-size char buffer + strlcpy/strlcat with FileSystem::removeExtension + AsciiString::concat in both saveTracks and loadTracks; fix is consistent, logically sound, and eliminates the 256-byte buffer truncation risk.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant WaterTracksRenderSystem
    participant TerrainLogic
    participant FileSystem

    Caller->>WaterTracksRenderSystem: saveTracks() / loadTracks()
    WaterTracksRenderSystem->>TerrainLogic: getSourceFilename()
    TerrainLogic-->>WaterTracksRenderSystem: "Maps/MyMap.map"
    WaterTracksRenderSystem->>FileSystem: removeExtension(fileName)
    Note over FileSystem: strrchr finds '.' → truncateTo drops ".map"
    FileSystem-->>WaterTracksRenderSystem: fileName = "Maps/MyMap"
    WaterTracksRenderSystem->>WaterTracksRenderSystem: fileName.concat(".wak")
    Note over WaterTracksRenderSystem: fileName = "Maps/MyMap.wak"
    WaterTracksRenderSystem->>FileSystem: openFile("Maps/MyMap.wak", READ|BINARY)

Loading

_{Reviews (4): Last reviewed commit: "fix(W3DWaterTracks): Correct the path ha..." | Re-trigger Greptile}

[Mauller]

I have made a new PR to extend the functionality of AsciiString and UnicodeString with a removeExtensions() function that will remove all file extensions from a path.

The implementation relies on looking for the first full stop symbol denoting the first extension in the path name.
It then truncates the entire string up to this point.

I tested it by substituting it in where i was performing the fileName.truncateBy(sizeof(".map") - 1); and it worked for AsciiStrings. UnicodeString should work the same.

[Mauller]

Updated the implementation after all of the new file extension handling code was merged.

The comparison will be large but the change is simple to just see in the change screen.

Also waves!

[Mauller]

Updated the implementation to remove the raw c-string handling.

[xezon]

or FileSystem::removeExtension

[Mauller]

Oh yes, i forgot i made it static.

[Mauller]

Tweaked to call the static function on the class instead of the instance of the file system.