Skip to content

perf+feat: Morse hot path, Metatomic keys (#215), ASE srun (#193)#353

Closed
HaoZeke wants to merge 0 commit into
TheochemUI:mainfrom
HaoZeke:develop
Closed

perf+feat: Morse hot path, Metatomic keys (#215), ASE srun (#193)#353
HaoZeke wants to merge 0 commit into
TheochemUI:mainfrom
HaoZeke:develop

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • CI green (towncrier, lints, Morse-using NEB tests)
  • Optional: re-run cachegrind on same NEB Morse case for Ir delta

HaoZeke added a commit to HaoZeke/eOn that referenced this pull request Jun 27, 2026
Address review on TheochemUI#353: misspelled energy_uncertainty_output must not
leave uncertainty_threshold active with no map. Restore Morse fmag/r
for bit-stable forces vs main.
HaoZeke added a commit to HaoZeke/eOn that referenced this pull request Jun 27, 2026
Explicit energy_uncertainty_output missing from the model aborts
construction instead of soft-disabling uncertainty under a debug log
(review TheochemUI#353 / Codex).
@github-actions

Copy link
Copy Markdown

Benchmark Results

Warning

1 benchmark(s) regressed

Count
🔴 Regressed 1
🟢 Improved 1
⚪ Unchanged 6

Regressions

Benchmark Before After Ratio
🔴 bench_eonclient.TimeNEBMorsePt.time_neb 262±0ms 296±0ms 1.13x

Improvements

Benchmark Before After Ratio
🟢 bench_eonclient.TimePointMorsePt.time_point_evaluation 9.78±0ms 8.03±0ms 0.82x
6 unchanged benchmark(s)
Benchmark Before After Ratio
bench_eonclient.TimeMinimizationLJCluster.peakmem_minimization_lbfgs 41.2M 41.2M ~1x
bench_eonclient.TimeMinimizationLJCluster.time_minimization_lbfgs 33.5±0ms 33.7±0ms ~1x
bench_eonclient.TimeNEBMorsePt.peakmem_neb 41M 41M ~1x
bench_eonclient.TimePointMorsePt.peakmem_point_evaluation 41.2M 41.1M ~1x
bench_eonclient.TimeSaddleSearchMorseDimer.peakmem_saddle_search_dimer 41M 40.9M ~1x
bench_eonclient.TimeSaddleSearchMorseDimer.time_saddle_search_dimer 68.2±0ms 63.4±0ms ~0.93x
Details
  • Base: 0a40bb30
  • Head: 7b9f0825
  • Runner: ubuntu-22.04
Raw asv-spyglass output
All benchmarks:

| Change   | Before   | After    |   Ratio | Benchmark (Parameter)                                                  |
|----------|----------|----------|---------|------------------------------------------------------------------------|
|          | 41.2M    | 41.2M    |    1    | bench_eonclient.TimeMinimizationLJCluster.peakmem_minimization_lbfgs   |
|          | 33.5±0ms | 33.7±0ms |    1    | bench_eonclient.TimeMinimizationLJCluster.time_minimization_lbfgs      |
|          | 41M      | 41M      |    1    | bench_eonclient.TimeNEBMorsePt.peakmem_neb                             |
| +        | 262±0ms  | 296±0ms  |    1.13 | bench_eonclient.TimeNEBMorsePt.time_neb                                |
|          | 41.2M    | 41.1M    |    1    | bench_eonclient.TimePointMorsePt.peakmem_point_evaluation              |
| -        | 9.78±0ms | 8.03±0ms |    0.82 | bench_eonclient.TimePointMorsePt.time_point_evaluation                 |
|          | 41M      | 40.9M    |    1    | bench_eonclient.TimeSaddleSearchMorseDimer.peakmem_saddle_search_dimer |
|          | 68.2±0ms | 63.4±0ms |    0.93 | bench_eonclient.TimeSaddleSearchMorseDimer.time_saddle_search_dimer    |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant