perf+feat: Morse hot path, Metatomic keys (#215), ASE srun (#193)#353
Closed
HaoZeke wants to merge 0 commit into
Closed
perf+feat: Morse hot path, Metatomic keys (#215), ASE srun (#193)#353HaoZeke wants to merge 0 commit into
HaoZeke wants to merge 0 commit into
Conversation
This was referenced Jun 27, 2026
HaoZeke
added a commit
to HaoZeke/eOn
that referenced
this pull request
Jun 27, 2026
Address review on TheochemUI#353: misspelled energy_uncertainty_output must not leave uncertainty_threshold active with no map. Restore Morse fmag/r for bit-stable forces vs main.
HaoZeke
added a commit
to HaoZeke/eOn
that referenced
this pull request
Jun 27, 2026
Explicit energy_uncertainty_output missing from the model aborts construction instead of soft-disabling uncertainty under a debug log (review TheochemUI#353 / Codex).
Benchmark ResultsWarning 1 benchmark(s) regressed
Regressions
Improvements
6 unchanged benchmark(s)
Details
Raw asv-spyglass output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmp_neb_profile/cachegrind.out(~60% Ir inMorse::forceon NEB Morse): inline pair potential, inv-r force scale, pointer-based force accumulation.[Metatomic] energy_output/energy_uncertainty_outputfor non-default model output names (variants still work).srunin the ASE calculators better #193:[ASE_NWCHEM] mpi_launcher(mpirundefault orsrun).Test plan