Dev language - #161
Open
Mandvii wants to merge 38 commits into
Open
Conversation
… users to change the application's language independently of the system settings.
…ity to use Android's built-in per-app language support.
…rious code formatting inconsistencies within the `SettingsViewModel`, including spacing and line breaks.
unique internal code, `system_default_internal`, is now used to represent the "System Default" language option, preventing potential conflicts with actual language codes like "en".
This commit refactors the application's language handling by removing the `RespectMobileSystemCommon` class and consolidating its logic and data structures into `SupportedLanguagesConfig`.
# Conflicts: # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/domain/applanguage/SupportedLanguagesConfig.kt # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/onboarding/OnboardingViewModel.kt # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/settings/SettingsViewModel.kt
This commit enhances the `LanguageDropdown` component with the following changes:
* **UI Text:** Replaces the generic "Language" label with the more descriptive "Choose your language" to improve user experience.
* **Testability:** Adds a `testTag("choose_language")` to the `ExposedDropdownMenuBox` to make the component easier to find and interact with in UI tests.
* **Cleanup:** Removes an unused string resource import (`Res.string.language`).
…sers, regardless of their admin status or developer mode settings. RemoveD Mappings button from Settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In app langage selection-