refactor(android): drop the two call callbacks Android never delivers (WT-1156) - #368
Merged
SERDUN merged 1 commit intoAug 19, 2026
Merged
Conversation
The calling plugin offered two events that only an iPhone can produce: continuing a call started from the system's own recents or voice assistant, and the reset the system sends when it drops every call it was tracking. On Android nothing has ever raised either of them, yet both looked like part of the shared contract, inviting Android logic that could never run. Both are now removed from the Android side and marked as iOS-only in the shared interface and the documentation, so the contract says what actually happens. The version of the tool that produces the generated message files is pinned alongside, so those files stay stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The calling plugin advertised two events that only an iPhone can produce: continuing a call that the user started from the system's own recents list or voice assistant, and the reset the system sends when it drops every call it was tracking. On Android nothing has ever raised either of them - not in any release line, and not in any captured session on a device - yet both sat in the shared contract as if they were cross-platform, inviting Android logic that could never run.
Both are now removed from the Android side, and the shared interface plus the documentation say plainly that they are delivered by iOS only, with a short note on why Android has no equivalent. Nothing that works today changes: the iPhone path is untouched, and the applications that implement the interface keep both methods because iOS still uses them.
The version of the tool that produces the generated message files is pinned in the same pass, so those files stop drifting between machines.
Verification
Analysis is clean apart from the two pre-existing notices about a deprecated generator option. The Dart suites pass in every package - the three tests that only exercised the removed channels are gone with them - and the native unit tests build and pass, which also proves nothing on the platform side referenced the removed methods.