drop stale ENABLE_REGISTRY_VALIDATION env var - #623
Open
MsfPablo wants to merge 1 commit into
Open
Conversation
The OSS Helm chart, the chart unit tests, the local docker-compose, and .env.example still rendered AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION as an active knob, but the current server config no longer reads it. Registry validation is now controlled by types.AppOptions.RegistryValidator. Removes: - config.enableRegistryValidation (values.yaml + README.md table) - AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION (configmap.yaml template, docker-compose.yml, .env.example) - chart unit test that asserted the removed env var Refs issue agentregistry-dev#566. Pure deletion, no behavior change for callers already on the AppOptions.RegistryValidator path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATIONandconfig.enableRegistryValidationeverywhere they're rendered as if they were an active runtime knob.Why
Issue #566 — the OSS Helm chart and the local docker-compose both still render this env var, but the current server config no longer reads it. The actual validation path goes through
types.AppOptions.RegistryValidatorand the v1alpha1 resource handlers. The chart value looks like a working toggle when it is dead surface.The reporter's suggested cleanup, applied here:
config.enableRegistryValidationfrom the chartvalues.yaml, the regeneratedREADME.md, theconfigmap.yamltemplate, and the chart unit test that asserts on it.AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATIONline from the localdocker/docker-compose.yml.# Registry Validationblock from.env.example.Changes
Test plan
go build ./...cleanmake charts-docsregenerates the README with the table row removed (noconfig.enableRegistryValidationentry in the Parameters table)grep -rn 'ENABLE_REGISTRY_VALIDATION\|enableRegistryValidation'over*.go *.yaml *.yml *.md *.example *.tplreturns no hitshelm-unittestis not installed in this environment; the chart unit test that asserted on the removed env var was deleted alongside it (it would otherwise fail on this PR). Operators withhelm-unittestshould runhelm unittest charts/agentregistrylocally.Notes
types.AppOptions.RegistryValidator(per the reporter's guidance). Any deployment that still setsAGENT_REGISTRY_ENABLE_REGISTRY_VALIDATIONwill see it ignored — no behavior change for callers already on the new validator path.AGENT_REGISTRY_SERVER_ADDRESS,AGENT_REGISTRY_MCP_PORT) are untouched.