Skip to content

drop stale ENABLE_REGISTRY_VALIDATION env var #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MsfPablo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drop stale ENABLE_REGISTRY_VALIDATION env var #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ AGENT_REGISTRY_DATABASE_URL=postgres://localhost:5432/agentregistry?sslmode=disa
# Set automatically during build, can be overridden for development
AGENT_REGISTRY_VERSION=dev

# Registry Validation
# Enable validation of registry package references
AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION=false

# MCP Registry v0.1 Compatibility (read-only)
# Re-exposes MCPServer resources in the official server.json shape at
# /v0.1/servers so registry-aware clients (e.g. VS Code's MCP gallery) can
Expand Down
1 change: 0 additions & 1 deletion charts/agentregistry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ This creates a `Role`/`RoleBinding` in each listed namespace (plus the installat
| commonAnnotations | object | `{}` | Annotations to add to all deployed resources |
| commonLabels | object | `{}` | Labels to add to all deployed resources |
| config.agentRegistryMcpPort | string | `"31313"` | Agent Registry MCP server port |
| config.enableRegistryValidation | string | `"false"` | Enable input validation on the registry API |
| config.serverAddress | string | `":8080"` | Listen address for the HTTP server |
| containerSecurityContext.allowPrivilegeEscalation | bool | `false` | Allow privilege escalation |
| containerSecurityContext.capabilities.drop | list | `["ALL"]` | Linux capabilities to drop |
Expand Down
1 change: 0 additions & 1 deletion charts/agentregistry/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,3 @@ metadata:
data:
AGENT_REGISTRY_SERVER_ADDRESS: {{ .Values.config.serverAddress | quote }}
AGENT_REGISTRY_MCP_PORT: {{ .Values.config.agentRegistryMcpPort | quote }}
AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION: {{ .Values.config.enableRegistryValidation | quote }}
6 changes: 0 additions & 6 deletions charts/agentregistry/tests/configmap_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@ tests:
path: data.AGENT_REGISTRY_MCP_PORT
value: "31313"

- it: sets AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION
asserts:
- equal:
path: data.AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION
value: "false"

- it: overrides serverAddress
set:
config.serverAddress: ":9090"
Expand Down
2 changes: 0 additions & 2 deletions charts/agentregistry/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ config:
serverAddress: ":8080"
# -- Agent Registry MCP server port
agentRegistryMcpPort: "31313"
# -- Enable input validation on the registry API
enableRegistryValidation: "false"

# @section Deployment parameters

Expand Down
2 changes: 0 additions & 2 deletions docker/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ services:
environment:
AGENT_REGISTRY_DATABASE_URL: "postgres://agentregistry:agentregistry@postgres:5432/agentregistry?sslmode=disable"
AGENT_REGISTRY_SERVER_ADDRESS: ":8080"
# Temporarily only for local development.
AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION: "false"
AGENT_REGISTRY_MCP_PORT: "31313"
KUBECONFIG: "/root/.kube/config"
ports:
Expand Down