Skip to content

Demote recompiling message from INFO to DEBUG (#333) - #1089

Merged
elharo merged 1 commit into
apache:masterfrom
elharo:debug-recompile-message
Aug 4, 2026
Merged

Demote recompiling message from INFO to DEBUG (#333)#1089
elharo merged 1 commit into
apache:masterfrom
elharo:debug-recompile-message

Conversation

@elharo

@elharo elharo commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Part of #333

Changes the 'Recompiling all files because ...' log message from INFO to DEBUG level. This message is emitted for every module during incremental builds and is noisy at the default log level.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces default build output noise during incremental builds by lowering the verbosity of the “Recompiling all files because …” reason message so it no longer appears at the default INFO level for every module.

Changes:

  • Changed the incremental full-rebuild “cause” log line from INFO to DEBUG in ToolExecutor.applyIncrementalBuild(...).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@elharo
elharo requested a review from ascheman August 4, 2026 20:23

@ascheman ascheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — demoting the per-module "Recompiling all files…" message to DEBUG is a sensible noise reduction for the default log level, and it's guarded by the existing !sourceFiles.isEmpty() check so it won't fire on empty sets. Thanks @elharo.

@elharo
elharo merged commit 4aba262 into apache:master Aug 4, 2026
20 checks passed
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

@elharo Please assign appropriate label to PR according to the type of change.

@desruisseaux

Copy link
Copy Markdown
Contributor

The comment in the review saying that we should probably keep the info level when the user explicitly requested that information (with the showCompilationChanges configuration option) has not been answered. There is also the issue that we currently flood the debug level with so many records that logging anything at this level is practically lost, because debug is often used as a trace level providing no way for users to debug their build configuration without being drowned in Maven internal details.

I have create pull request #1108 for the showCompilationChanges flag. About the flood at debug level, I have no solution for now, as this is wider problem that the compiler plugin. A solution may be to create a Log.trace method and demote many debug levels to trace among all Maven core and plugins.

@ascheman

ascheman commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

I have create pull request #1108 for the showCompilationChanges flag. About the flood at debug level, I have no solution for now, as this is wider problem that the compiler plugin. A solution may be to create a Log.trace method and demote many debug levels to trace among all Maven core and plugins.

I like this idea (we have discussed and applied it elsewhere already).

@elharo
elharo deleted the debug-recompile-message branch August 5, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants