Keep the recompiling message at the INFO level when user explicitly requested that information - #1108
Keep the recompiling message at the INFO level when user explicitly requested that information#1108desruisseaux wants to merge 1 commit into
Conversation
…equested that information.
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
A trace level below debug level sounds useful. I think we have defaulted to showing far too much logging that is never looked at and merely obscures real issues.
My rule of thumb is that every log message should be interesting, actionable, and useful, especially at info level or higher. It is not enough that someone might sometime want to see the log. To log at info level we need to be confident that most people will want to see it most of the time.
More needles, less hay. :-)
| * Whether to provide more details about why a module is rebuilt. | ||
| */ | ||
| private final boolean showCompilationChanges; | ||
| final boolean showCompilationChanges; |
There was a problem hiding this comment.
How does the user set this? Is there a paremter somewhere?
There was a problem hiding this comment.
Yes, this is a parameter in CompilerMojo. This parameter already existed in the Maven 3 plugin.
2 participants
Keep the recompiling message at the INFO level when user explicitly requested that information. This pull request narrows the scope of #1089 to the case when the user did not requested that information.