fix(boot): preserve reentrant root lifetimes during cleanup - #398
Merged
Conversation
smiggleworth
force-pushed
the
fix/root-lifetime-cleanup
branch
from
September 6, 2026 20:31
fe52868 to
232c968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cleanup could erase a replacement mounted by a cleanup callback: the old cleanup continued deleting the element's registration after the new mount completed. A stale callback unsubscribe could clear the new lifetime's callbacks, and the intercepted
innerHTML = ''setter could remove the replacement DOM after cleanup returned.Retire the root registration and capture its callbacks before teardown invokes user code. Restore a reusable instance only when no replacement claimed the root; a reentrant mount supersedes an interrupted update or DOM clear. Callback unsubscription checks collection identity. Shared root initialization and default portal cleanup registration are consolidated; public signatures and the bundle limit are unchanged.
Validation: