fix(client): populate all declared movement fixture depths - #541
Draft
zoeyrose wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Classic GPU qualification fixture generator so the wire fixture exercises all 13 declared map depths.
Implementation / behavior
The
wire_ceiling_payloadgenerator already declaredBENCHMARK_28_DEPTHSas-6..+6, and the two wire workloads requireactive_depths=13.Its qualification-layer branch was additionally gated by
depth == 0, so only one command depth was emitted. The patch removes that gate.The 64 actor layers remain depth-zero-only and the existing layer placement/seed logic is unchanged.
The corrected fixture decodes to 13 non-empty depth buckets with 64 actor occurrences and remains within the 65535-byte MAP2 packet limit.
Content remains pinned to
atrinik/contentmain/v1.7.0/08e8bc869d5d727d3862997176a137275f349869.Validation
python3 tools/verify_gpu_fixture_provenance.pypassed.python3 tools/verify_gpu_fixture_bytes.pypassed (47 inputs).python3 -m unittest -v tools.tests.test_movement_fixture tools.tests.test_gpu_fixture_bytes tools.tests.test_gpu_fixture_provenance tools.tests.test_verify_gpu_qualificationpassed (37 tests)../atrinik build all --profile scope-issue489-fixture-depths-20260904 --testcompiled the Classic stack; targetedclient-gpu-fixture-provenancepassed.v1.7.0staged-content provenance passed.client-window-title,server-unit-toolkit.socket_asset, andserver-assetspath-migration.Limitations / follow-up
The post-fix wire workload JSON was not generated in the headless Linux container. Native Windows GPU qualification should be rerun at this PR head; no renderer or guard changes are included.