Skip to content

fix(client): populate all declared movement fixture depths - #541

Draft
zoeyrose wants to merge 1 commit into
mainfrom
fix/client-movement-fixture-depth-coordinate-20260904-pr
Draft

fix(client): populate all declared movement fixture depths#541
zoeyrose wants to merge 1 commit into
mainfrom
fix/client-movement-fixture-depth-coordinate-20260904-pr

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

Fix the Classic GPU qualification fixture generator so the wire fixture exercises all 13 declared map depths.

Implementation / behavior

The wire_ceiling_payload generator already declared BENCHMARK_28_DEPTHS as -6..+6, and the two wire workloads require active_depths=13.
Its qualification-layer branch was additionally gated by depth == 0, so only one command depth was emitted. The patch removes that gate.
The 64 actor layers remain depth-zero-only and the existing layer placement/seed logic is unchanged.

The corrected fixture decodes to 13 non-empty depth buckets with 64 actor occurrences and remains within the 65535-byte MAP2 packet limit.
Content remains pinned to atrinik/content main / v1.7.0 / 08e8bc869d5d727d3862997176a137275f349869.

Validation

  • python3 tools/verify_gpu_fixture_provenance.py passed.
  • python3 tools/verify_gpu_fixture_bytes.py passed (47 inputs).
  • python3 -m unittest -v tools.tests.test_movement_fixture tools.tests.test_gpu_fixture_bytes tools.tests.test_gpu_fixture_provenance tools.tests.test_verify_gpu_qualification passed (37 tests).
  • ./atrinik build all --profile scope-issue489-fixture-depths-20260904 --test compiled the Classic stack; targeted client-gpu-fixture-provenance passed.
  • Exact v1.7.0 staged-content provenance passed.
  • The Linux container has no supported GPU, so GPU production tests were skipped. Aggregate CTest also retained three unrelated environment/runtime failures: client-window-title, server-unit-toolkit.socket_asset, and server-assetspath-migration.

Limitations / follow-up

The post-fix wire workload JSON was not generated in the headless Linux container. Native Windows GPU qualification should be rerun at this PR head; no renderer or guard changes are included.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@zoeyrose zoeyrose moved this to Review in Atrinik work Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

perf(client): finish GPU-native map rendering performance follow-up

1 participant