Move agent management into profile sidebar#1274
Draft
tellaho wants to merge 27 commits into
Draft
Conversation
Merge origin/main (36d3d2e) into Kenny's agent-profile-sidebar branch (309889d), resolving conflicts in three files: - ManagedAgentRow.tsx - UserProfilePanel.tsx - UserProfilePanelSections.tsx Ported #1198's clickable owner-avatar feature into Kenny's refactored owner-field path (useProfileFieldBuckets/buildOwnerFields in UserProfilePanelFields.tsx), adapting main's pre-bound onOpenOwner to Kenny's pubkey-taking onOpenProfile handler. Fixed a pre-existing test bug in Kenny's branch: personaManagedAgentUpdate tests expected avatarUrl in the output, but UpdateManagedAgentInput has no avatarUrl field and the function never sets it. Removed the impossible expected-output assertions (the avatarUrl sync is not implemented by design). Co-authored-by: Ned <ab176f059d100602ea25073d9a69ee9817f7b691c76a897180d48498d959faa2@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Weaves main's #1229 observability-ownership split (isOwner vs viewerIsOwner) into Kenny's agent-management-in-profile-sidebar refactor. Resolves conflicts in ManagedAgentRow.tsx and UserProfilePanel.tsx; UserProfilePanelSections.tsx auto-merged on main's MemoryFocusedView(viewerIsOwner) API. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Use the shared profile panel view parser for channel and Pulse URL search state so every focused profile subview survives navigation and reloads. - Replace the old memories/channels-only profileView whitelist in channel and Pulse route validation. - Expand the profile Playwright coverage to exercise agent instruction, model, settings, diagnostics/logs, channels, and memories ingress rows from a mock managed agent profile. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com> (cherry picked from commit dbad796)
- Reuse managed-agent runtime defaults, provider/model env injection, and Databricks defaults when querying agent models so discovery matches normal startup behavior. - Add a configurationError field to model discovery responses for known missing provider, model, or credential setup issues instead of treating them as generic subprocess failures. - Update the profile model picker to render actionable setup messaging for configuration gaps and reserve the red failure state for unexpected discovery errors. - Show provider-backed agents as remotely managed in the model focused view rather than exposing a local model picker. - Keep E2E Tauri mocks aligned with the expanded AgentModelsResponse shape. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Replace the Agent info summary ingress with the existing ProfileFieldGroup card for Public key and Owned by. - Preserve the shared muted background and adjacent field styling by reusing the focused profile field container. - Remove the now-unused Agent info summary click handler and Info icon import while leaving the focused info view available for other metadata. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Replace separate profile sidebar rows for agent instructions, model, and settings with a single Agent configuration ingress. - Add a combined configuration focused view that reuses the existing instruction, model picker, and settings sections under one destination. - Canonicalize legacy profileView values for instructions, model, and settings to configuration so existing deep links continue to resolve. - Update profile panel utility tests to cover the new canonical view and legacy aliases. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Move the agent activity log ingress to the top-level profile sidebar actions so Diagnostics focuses on operational status and logs. - Render Diagnostics status with the existing agent status badge instead of plain summary text. - Embed the Harness log directly in Diagnostics and use flex sizing so the terminal fills the available height while the log body scrolls internally. - Collapse Harness log chrome into the terminal frame with a compact dark copy action and footer-mounted log filename. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Add a compact shared Alert primitive matching the profile sidebar density with base foreground text and soft background variants. - Render Diagnostics last errors as a destructive alert instead of a standard metadata field row. - Prioritize an Error badge on the top-level Diagnostics ingress when a last error is present. - Move the Harness log filename directly under the terminal header title and remove the footer metadata row. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Move model, instructions, runtime, ACP command, and MCP command behind a profile subpage labeled Advanced - Keep summary profile details read-only and ordered as public key, owner, respond-to, then Advanced - Render owner-only respond-to values with the owner avatar and display name - Split auto-start into the bottom profile actions as a switch control - Extract advanced agent detail rows from the oversized profile sections module to satisfy desktop file-size checks Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
When a managed agent responds only to its owner, collapse the separate Owned by and Respond to rows into a single Owned by & responds to field. Surface the agent info summary fields regardless of viewer ownership. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Replace the inline profile agent action rows with a header settings menu in UserProfileAgentActions. - Wire the cog into UserProfilePanel next to the close button and scope it to the summary view so interior views keep focused headers. - Extract the profile panel frame into UserProfilePanelFrame to keep UserProfilePanel under the desktop file-size guard. - Trim obsolete action props and rendering from ProfileSummaryView after moving duplicate, export, autostart, and delete into the menu. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Use the current user's profile avatar when an agent owner row is rendered from the local "you" ownership fallback. - Reuse a shared owner row content node so both clickable owner links and copyable fallback rows render the owner avatar beside the label. - Preserve the existing copy behavior for fallback owner rows while restoring the avatar treatment added for NIP-OA owners. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Move the top-level agent details card above the Memories, Channels, Diagnostics, and Activity ingress rows in the profile summary. - Keep the existing public key, ownership, agent detail, and Advanced row rendering intact while changing only the visual order. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Replace stacked ingress rows with inline Info, Runtime, Channels, and Memories tabs below the profile action buttons so agent details stay on one screen. - UserProfilePanelTabs: secondary/ghost Button tabs, momentum drag-scroll, Info/Runtime tab content, shared ProfileIngressRow - UserProfilePanelSections: wire tabs into ProfileSummaryView - Info tab: instructions first, identity fields, activity log ingress - Runtime tab: model, runtime config, respond-to, diagnostics ingress - Split combined owned-by/respond-to into separate fields - Rename Advanced focused view title to Runtime - profile.spec.ts: update E2E to click tabs instead of ingress rows Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Hide the profile tab bar when Info is the only available section, keeping simple human profiles focused on the visible fields. - Split the agent Status diagnostics row out of the runtime details so it appears above runtime configuration. - Preserve the existing multi-tab agent profile behavior for Runtime, Channels, and Memories. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Rename the profile Diagnostics focused view and Runtime tab ingress to Harness Log so the user-facing label matches the pane content. - Keep agent Status in the Runtime tab summary area while filtering it out of the focused Harness Log pane. - Normalize Harness Log casing in the managed agent log panel and update the profile E2E assertion for the new pane title and missing Status row. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Add an `instructions` profile subview so agent instructions use the same body-replacement and back-button pattern as Harness Log. - Change the summary instructions row to a two-line preview with a chevron instead of an in-place scroll/expand region. - Render full instructions Markdown in the focused view while keeping the preview as plain clamped text inside the clickable row. - Extract profile panel header actions into `UserProfilePanelHeaderContent` to keep `UserProfilePanel.tsx` under the desktop file-size guard. - Update profile view parsing tests and the profile E2E flow to cover the new instructions subview. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Keep profile-launched activity panels open by preserving profile state and resolving activity sessions outside the active channel list. - Allow activity panels to render an unscoped feed when opened from a profile for agents outside the current channel. - Move Activity log, Harness Log, and Instructions ingresses into the requested profile tab order. - Make Owned by rows full-width profile actions with trailing ArrowUpRight affordances across channel, pulse, and agents profile panels. - Extract selected agent-session resolution from ChannelPane to stay under desktop file-size limits. - Extend the profile e2e coverage for the activity panel close/return flow. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Move the agent instructions ingress to the top of the runtime tab content. - Keep the status diagnostics and harness log ingress below instructions so the highest-value editable guidance is visible first. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Replace visible profile quick-action labels with shadcn tooltip content above each circular button. - Keep profile action controls centered and accessible with aria labels on the icon buttons. - Slightly reduce the original oversized circles while preserving the active/inactive visual treatments. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Add profileTab route search parsing and validation for channel, pulse, and agents routes so profile summary tabs are reflected in browser history. - Move channel and pulse profile panels onto controlled tab state while preserving existing profileView focused subview routing. - Convert Agents profile panels from local React state to URL-backed profile/profilePersona/profileTab/profileView state so profile panels, persona panels, tabs, and focused views survive back/forward and reloads. - Extend profile utility tests and the profile Playwright flow to assert URL params and back/forward restoration for tab changes. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Update the Memories tab empty view to match the ACP activity empty-state structure. - Add the centered icon, title, description, and spacing treatment so the empty panel feels consistent with nearby profile panes. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Extract repeated profile panel row/surface patterns, runtime labels, working badges, avatar-with-presence, popover triggers, and list identity rows into shared components so profile, sidebar, channel, message, pulse, and forum surfaces use one consistent visual language without changing test ids. - Add ProfilePanelPrimitives, AgentWorkingBadge, ProfileAvatarWithPresence, ProfileIdentityTrigger, ProfileListIdentity, and agentLabels helper - Refactor profile panel fields, tabs, agent details, sections, and popover - Adopt shared primitives in sidebar, members, DM search, messages, pulse, forum - Rename ProfileIdentityTrigger role prop to authorRole to satisfy a11y lint Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Update the agent profile ingress E2E flow to use the activity panel back action when returning to the profile panel - Keep the test aligned with the current split-panel behavior where closing the activity panel dismisses the side panel instead of restoring profile details - Preserve coverage for profile tab routing, activity ingress, diagnostics, channels, and memories after the branch's profile panel changes Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
- Add channel-level active turn aggregation in activeAgentTurnsStore so sidebar rows can subscribe to active work by channel - Mount the managed agent observer and active-turn bridges from AppSidebar to keep channel badges live without visiting agent/profile surfaces - Render compact working badges on channel rows across starred, custom, stream, forum, and direct-message sections - Cover channel aggregation behavior for multi-agent activity and last-turn completion in activeAgentTurnsStore tests Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Captures PR-ready screenshots of the profile sidebar views (summary, agent details/instructions, diagnostics, activity, channels, memory) for both agent (owner) and human (read-only) profiles. Includes the Cargo.lock update for the security-framework dependency. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move agent management into the profile sidebar
Replaces #1200 (Kenny's PR). This is a fresh branch (
tho/agent-profile-sidebar) based onmainrather than stacked on Kenny's head — opening as a draft.What this does
Moves agent management into the profile sidebar and makes the pane mostly read-only — the Edit modal owns actual mutations. The polish includes:
Owner sees management actions; non-owner pane stays read-only as intended.
Review & screenshots
Marge walked every profile-sidebar view — all 10 shots verified clean, no broken features found. Both agent (owner) and human (read-only) profiles captured so the read-only-vs-owner contrast shows.
Agent (owner) profile:
Human (read-only) profile:
Notes
desktop/tests/e2e/profile-sidebar-screenshots.spec.ts).Cargo.lockchange (addssecurity-framework 3.7.0).Replaces #1200.