Move agent management into profile sidebar

desktop/src-tauri/src/commands/agent_models.rs

@@ -6,12 +6,12 @@ use tauri::{AppHandle, State};
 use crate::{
     app_state::AppState,
     managed_agents::{
-        build_managed_agent_summary, default_agent_workdir, find_managed_agent_mut,
-        known_acp_runtime, load_managed_agents, load_personas, managed_agent_avatar_url,
-        missing_command_message, normalize_agent_args, resolve_command,
-        resolve_effective_prompt_model_provider, save_managed_agents, sync_managed_agent_processes,
-        try_regenerate_nest, AgentModelInfo, AgentModelsResponse, UpdateManagedAgentRequest,
-        UpdateManagedAgentResponse,
+        build_databricks_defaults, build_managed_agent_summary, default_agent_workdir,
+        find_managed_agent_mut, known_acp_runtime, load_managed_agents, load_personas,
+        managed_agent_avatar_url, missing_command_message, normalize_agent_args, resolve_command,
+        resolve_effective_prompt_model_provider, runtime_metadata_env_vars, save_managed_agents,
+        sync_managed_agent_processes, try_regenerate_nest, AgentModelInfo, AgentModelsResponse,
+        UpdateManagedAgentRequest, UpdateManagedAgentResponse,
     },
     relay::{relay_ws_url_with_override, sync_managed_agent_profile},
     util::now_iso,
@@ -27,7 +27,16 @@ pub async fn get_agent_models(
     app: AppHandle,
     state: State<'_, AppState>,
 ) -> Result<AgentModelsResponse, String> {
-    let (resolved_acp, agent_command, agent_args, persisted_model, merged_env) = {
+    let (
+        resolved_acp,
+        agent_command,
+        agent_args,
+        persisted_model,
+        runtime_default_env,
+        runtime_metadata_env,
+        databricks_defaults,
+        merged_env,
+    ) = {
         let _store_guard = state
             .managed_agents_store_lock
             .lock()
@@ -75,14 +84,51 @@ pub async fn get_agent_models(
 
         // Resolve the effective model from the linked persona so the ModelPicker
         // dropdown shows the current persona model as selected.
-        let (_prompt, effective_model, _provider) = resolve_effective_prompt_model_provider(
-            record.persona_id.as_deref(),
-            &personas,
-            record.system_prompt.clone(),
-            record.model.clone(),
-        );
-
-        (resolved, resolved_agent, args, effective_model, env)
+        let (_prompt, effective_model, effective_provider) =
+            resolve_effective_prompt_model_provider(
+                record.persona_id.as_deref(),
+                &personas,
+                record.system_prompt.clone(),
+                record.model.clone(),
+            );
+        let runtime = known_acp_runtime(&record.agent_command);
+        let runtime_default_env: Vec<(String, String)> = runtime
+            .map(|meta| {
+                meta.default_env
+                    .iter()
+                    .map(|(key, value)| ((*key).to_string(), (*value).to_string()))
+                    .collect()
+            })
+            .unwrap_or_default();
+        let runtime_metadata_env: Vec<(String, String)> = runtime
+            .map(|meta| {
+                runtime_metadata_env_vars(
+                    meta.model_env_var,
+                    meta.provider_env_var,
+                    meta.provider_locked,
+                    effective_model.as_deref(),
+                    effective_provider.as_deref(),
+                )
+                .into_iter()
+                .map(|(key, value)| (key.to_string(), value.to_string()))
+                .collect()
+            })
+            .unwrap_or_default();
+        let databricks_defaults: Vec<(String, String)> = build_databricks_defaults()
+            .into_iter()
+            .map(|(key, value)| (key.to_string(), value.to_string()))
+            .collect();
+
+        (
+            resolved,
+            resolved_agent,
+            args,
+            effective_model,
+            runtime_default_env,
+            runtime_metadata_env,
+            databricks_defaults,
+            env,
+        )
     }; // store lock released — subprocess runs without holding the lock
 
     // Clone the env map for redaction below — `merged_env` is moved
@@ -105,13 +151,17 @@ pub async fn get_agent_models(
             .arg("--json")
             .env("BUZZ_ACP_AGENT_COMMAND", &agent_command)
             .env("BUZZ_ACP_AGENT_ARGS", agent_args.join(","));
-        if let Some(meta) = known_acp_runtime(&agent_command) {
-            for (key, value) in meta.default_env {
-                if std::env::var(key).is_err() {
-                    cmd.env(key, value);
-                }
+        for (key, value) in &runtime_default_env {
+            if std::env::var(key).is_err() {
+                cmd.env(key, value);
             }
         }
+        for (key, value) in &runtime_metadata_env {
+            cmd.env(key, value);
+        }
+        for (key, value) in &databricks_defaults {
+            cmd.env(key, value);
+        }
         // User env layering — written LAST so it overrides any Buzz-set env above.
         for (k, v) in &merged_env {
             cmd.env(k, v);
@@ -132,6 +182,12 @@ pub async fn get_agent_models(
         // a failing child process echoed back.
         let stderr_redacted =
             crate::managed_agents::redact_env_values_in(stderr.as_ref(), &env_for_redaction);
+        if let Some(configuration_error) = model_configuration_error(&stderr_redacted) {
+            return Ok(unavailable_agent_models(
+                persisted_model,
+                configuration_error,
+            ));
+        }
         return Err(format!(
             "buzz-acp models failed (exit {}): {stderr_redacted}",
             output.status.code().unwrap_or(-1)
@@ -413,5 +469,53 @@ fn normalize_agent_models(
         agent_default_model,
         selected_model: persisted_model,
         supports_switching,
+        configuration_error: None,
+    }
+}
+
+fn unavailable_agent_models(
+    persisted_model: Option<String>,
+    configuration_error: String,
+) -> AgentModelsResponse {
+    AgentModelsResponse {
+        agent_name: "unknown".to_string(),
+        agent_version: "unknown".to_string(),
+        models: Vec::new(),
+        agent_default_model: None,
+        selected_model: persisted_model,
+        supports_switching: false,
+        configuration_error: Some(configuration_error),
+    }
+}
+
+fn model_configuration_error(stderr: &str) -> Option<String> {
+    let normalized = stderr.to_ascii_lowercase();
+
+    if normalized.contains("buzz_agent_provider required") {
+        return Some(
+            "This agent does not have an LLM provider configured. Set a provider and model on the persona or agent, then retry."
+                .to_string(),
+        );
     }
+
+    if normalized.contains("anthropic_model required")
+        || normalized.contains("openai_compat_model required")
+        || normalized.contains("databricks_model required")
+    {
+        return Some(
+            "This agent does not have an LLM model configured. Set a model on the persona or agent, then retry."
+                .to_string(),
+        );
+    }
+
+    if normalized.contains("anthropic_api_key required")
+        || normalized.contains("openai_compat_api_key required")
+    {
+        return Some(
+            "This agent is missing credentials for its configured LLM provider. Add the provider credentials, then retry."
+                .to_string(),
+        );
+    }
+
+    None
 }

desktop/src-tauri/src/managed_agents/runtime.rs

@@ -1845,7 +1845,7 @@ fn child_rust_log_filter() -> String {
 
 /// Databricks host/model baked in at compile time for internal builds. Empty
 /// in OSS builds, where the `BUZZ_BUILD_DATABRICKS_*` env is unset.
-fn build_databricks_defaults() -> Vec<(&'static str, &'static str)> {
+pub(crate) fn build_databricks_defaults() -> Vec<(&'static str, &'static str)> {
     let mut defaults = Vec::new();
     if let Some(host) = option_env!("BUZZ_DESKTOP_BUILD_DATABRICKS_HOST") {
         if !host.is_empty() {
@@ -1977,7 +1977,7 @@ pub fn stop_managed_agent_process(
 /// switching need the initial bootstrap value. Provider injection is skipped
 /// when `provider_locked` is true (e.g. Claude runtimes that only work with
 /// Anthropic).
-fn runtime_metadata_env_vars<'a>(
+pub(crate) fn runtime_metadata_env_vars<'a>(
     model_env_var: Option<&'a str>,
     provider_env_var: Option<&'a str>,
     provider_locked: bool,

desktop/src-tauri/src/managed_agents/types.rs

@@ -535,6 +535,8 @@ pub struct AgentModelsResponse {
     pub selected_model: Option<String>,
     /// Whether this agent supports model switching.
     pub supports_switching: bool,
+    /// Human-readable setup issue that prevents model discovery.
+    pub configuration_error: Option<String>,
 }
 
 /// A single model available from an agent.

desktop/src/app/routes/agents.tsx

@@ -1,14 +1,43 @@
 import * as React from "react";
 import { createFileRoute } from "@tanstack/react-router";
 
+import {
+  parseProfilePanelTab,
+  parseProfilePanelView,
+  type ProfilePanelTab,
+  type ProfilePanelView,
+} from "@/features/profile/ui/UserProfilePanelUtils";
 import { ViewLoadingFallback } from "@/shared/ui/ViewLoadingFallback";
 
+type AgentsRouteSearch = {
+  profile?: string;
+  profilePersona?: string;
+  profileTab?: ProfilePanelTab;
+  profileView?: ProfilePanelView;
+};
+
+function nonEmptyString(value: unknown): string | undefined {
+  return typeof value === "string" && value.length > 0 ? value : undefined;
+}
+
+function validateAgentsSearch(
+  search: Record<string, unknown>,
+): AgentsRouteSearch {
+  return {
+    profile: nonEmptyString(search.profile),
+    profilePersona: nonEmptyString(search.profilePersona),
+    profileTab: parseProfilePanelTab(search.profileTab) ?? undefined,
+    profileView: parseProfilePanelView(search.profileView) ?? undefined,
+  };
+}
+
 const AgentsScreen = React.lazy(async () => {
   const module = await import("@/features/agents/ui/AgentsScreen");
   return { default: module.AgentsScreen };
 });
 
 export const Route = createFileRoute("/agents")({
+  validateSearch: validateAgentsSearch,
   component: AgentsRouteComponent,
 });
 

desktop/src/app/routes/channels.$channelId.tsx

@@ -1,13 +1,20 @@
 import * as React from "react";
 import { createFileRoute } from "@tanstack/react-router";
 
+import {
+  parseProfilePanelTab,
+  parseProfilePanelView,
+  type ProfilePanelTab,
+  type ProfilePanelView,
+} from "@/features/profile/ui/UserProfilePanelUtils";
 import { ViewLoadingFallback } from "@/shared/ui/ViewLoadingFallback";
 
 type ChannelRouteSearch = {
   agentSession?: string;
   messageId?: string;
   profile?: string;
-  profileView?: "memories" | "channels";
+  profileTab?: ProfilePanelTab;
+  profileView?: ProfilePanelView;
   thread?: string;
   threadRootId?: string;
 };
@@ -16,18 +23,15 @@ function nonEmptyString(value: unknown): string | undefined {
   return typeof value === "string" && value.length > 0 ? value : undefined;
 }
 
-function profileViewValue(value: unknown): "memories" | "channels" | undefined {
-  return value === "memories" || value === "channels" ? value : undefined;
-}
-
 function validateChannelSearch(
   search: Record<string, unknown>,
 ): ChannelRouteSearch {
   return {
     agentSession: nonEmptyString(search.agentSession),
     messageId: nonEmptyString(search.messageId),
     profile: nonEmptyString(search.profile),
-    profileView: profileViewValue(search.profileView),
+    profileTab: parseProfilePanelTab(search.profileTab) ?? undefined,
+    profileView: parseProfilePanelView(search.profileView) ?? undefined,
     thread: nonEmptyString(search.thread),
     threadRootId: nonEmptyString(search.threadRootId),
   };

desktop/src/app/routes/pulse.tsx

@@ -1,6 +1,12 @@
 import * as React from "react";
 import { createFileRoute } from "@tanstack/react-router";
 
+import {
+  parseProfilePanelTab,
+  parseProfilePanelView,
+  type ProfilePanelTab,
+  type ProfilePanelView,
+} from "@/features/profile/ui/UserProfilePanelUtils";
 import { usePreviewFeatureWarning } from "@/shared/features";
 import { ViewLoadingFallback } from "@/shared/ui/ViewLoadingFallback";
 
@@ -11,7 +17,8 @@ const PulseScreen = React.lazy(async () => {
 
 type PulseRouteSearch = {
   profile?: string;
-  profileView?: "memories" | "channels";
+  profileTab?: ProfilePanelTab;
+  profileView?: ProfilePanelView;
 };
 
 function validatePulseSearch(
@@ -22,10 +29,8 @@ function validatePulseSearch(
       typeof search.profile === "string" && search.profile.length > 0
         ? search.profile
         : undefined,
-    profileView:
-      search.profileView === "memories" || search.profileView === "channels"
-        ? search.profileView
-        : undefined,
+    profileTab: parseProfilePanelTab(search.profileTab) ?? undefined,
+    profileView: parseProfilePanelView(search.profileView) ?? undefined,
   };
 }
 

desktop/src/features/agent-memory/ui/MemorySection.tsx

@@ -1,5 +1,5 @@
 import * as React from "react";
-import { AlertTriangle, ChevronDown, RefreshCw } from "lucide-react";
+import { AlertTriangle, Brain, ChevronDown, RefreshCw } from "lucide-react";
 
 import { useAgentMemoryGraph } from "@/features/agent-memory/hooks";
 import type { MemoryTreeNode } from "@/features/agent-memory/lib/buildMemoryGraph";
@@ -225,12 +225,16 @@ function MemoryGraphView({
   const isEmpty = !rootedTree && orphans.length === 0;
   if (isEmpty) {
     return (
-      <p
-        className="text-sm italic text-muted-foreground"
+      <div
+        className="flex min-h-56 flex-col items-center justify-center px-6 py-10 text-center"
         data-testid="agent-memory-empty"
       >
-        This agent has no memories yet.
-      </p>
+        <Brain className="mx-auto h-4 w-4 text-muted-foreground" />
+        <p className="mt-3 text-sm font-medium">No memories yet</p>
+        <p className="mt-1 text-sm text-muted-foreground">
+          This agent has no memories yet.
+        </p>
+      </div>
     );
   }