Conversation
| # Allow single letters, constants (ALL_CAPS), and private names | ||
| if len(name_of_var) == 1 or name_of_var.isupper() or name_of_var.startswith('_'): | ||
| # Allow single letters, constants (ALL_CAPS), private names, and visit_ functions | ||
| if len(name_of_var) == 1 or name_of_var.isupper() or name_of_var.startswith('_') or name_of_var.startswith('visit_'): |
Contributor
There was a problem hiding this comment.
@47thomasj in the future, add a .standardignore file to TreeTapper repo (or whatever repo you are working on). There are simply to many cases where we inherit from a class that doesn't follow our naming standards. We don't need to update the check every time- that's too much work. Instead, just use the .standardignore file to indicate what variable names (or entire files) should be passed over when doing the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.