Skip to content

Stg #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
47thomasj merged 6 commits into from
Jul 14, 2025
Merged

Stg #41

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c98222
quick_fix
47thomasj Jul 14, 2025
b3ba497
Merge branch 'dev' into FixRandomFunctionNames
47thomasj Jul 14, 2025
30cf7bf
quick_fix (#39)
47thomasj Jul 14, 2025
9d9fb4b
Merge branch 'stg' into dev
47thomasj Jul 14, 2025
4c21257
Dev (#40)
47thomasj Jul 14, 2025
8cd6428
Merge branch 'prd' into stg
47thomasj Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/patterns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ def is_snake_case(name_of_var: str) -> bool:
Returns:
True if name is valid snake_case
"""
# Allow single letters, constants (ALL_CAPS), and private names
if len(name_of_var) == 1 or name_of_var.isupper() or name_of_var.startswith('_'):
# Allow single letters, constants (ALL_CAPS), private names, and visit_ functions
if len(name_of_var) == 1 or name_of_var.isupper() or name_of_var.startswith('_') or name_of_var.startswith('visit_'):
Copy link
Copy Markdown
Contributor

@JohnnyWeymouth JohnnyWeymouth Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@47thomasj in the future, add a .standardignore file to TreeTapper repo (or whatever repo you are working on). There are simply to many cases where we inherit from a class that doesn't follow our naming standards. We don't need to update the check every time- that's too much work. Instead, just use the .standardignore file to indicate what variable names (or entire files) should be passed over when doing the check.

return True

# Standard snake_case pattern
Expand Down
Loading