Skip to content

Add unlisted link publishing destination#5254

Open
backspace wants to merge 16 commits into
mainfrom
publish-to-obscure-cs-11581
Open

Add unlisted link publishing destination#5254
backspace wants to merge 16 commits into
mainfrom
publish-to-obscure-cs-11581

Conversation

@backspace

@backspace backspace commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This adds another publishing destination type: user.boxel-domain/random-string

s 2026-06-18 at 13 00 48

The /_unlisted-realm-path endpoint sets the random string for it because we don’t want the client to be able to choose the string.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Preview deployments

Host Test Results

    1 files  +    1      1 suites  +1   1h 58m 33s ⏱️ + 1h 58m 33s
3 140 tests +3 140  3 125 ✅ +3 125  15 💤 +15  0 ❌ ±0 
3 159 runs  +3 159  3 144 ✅ +3 144  15 💤 +15  0 ❌ ±0 

Results for commit df7fe60. ± Comparison against earlier commit b78b77d.

Realm Server Test Results

    1 files  ±0      1 suites  ±0   12m 29s ⏱️ +35s
1 749 tests ±0  1 749 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 842 runs  ±0  1 842 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit df7fe60. ± Comparison against earlier commit b78b77d.

@backspace backspace changed the title Change publishing from Boxel space to unlisted link Add unlisted link publishing destination Jun 18, 2026
@backspace backspace marked this pull request as ready for review June 19, 2026 21:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f76920d37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/realm-server/lib/unlisted-realm-path.ts
backspace and others added 2 commits June 19, 2026 16:41
… concurrent requests

Reserve slug overwrites for explicit regeneration; first-time allocation now
inserts-or-returns-existing so two overlapping requests converge on one slug.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Prevents a realm recreated at the same endpoint from reusing the prior
unguessable slug, which would expose it to holders of the old unlisted link.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant