fix(maestro): correct give-button label and sheet dismissal - #1181
Merged
Conversation
Two pre-existing flow failures on code/cash, unrelated to the beta-flag work: - The give nav button renders "Cash" (GiveButtonLabel.Cash / action_cash), not "Give", so pull_out_bill's `tapOn: Give` never matched. Tap "Cash". - close_open_sheet swiped down once and asserted the scanner, but a destination opened inside a sheet (wallet -> token info) is pushed onto that sheet's own nav stack, so one dismiss only pops a layer. Press Back until the scanner (the root behind the single sheet) is revealed — bounded and guarded so it can't hang CI or back out of the app. This fixes open_token_info_deeplink, which also drops its unasserted (silently no-op) deeplink reopen. Note: claim_cashlink and show_bill_and_put_back_in_wallet now tap Cash correctly but still require an account with a giveable balance (the give flow otherwise shows a deposit/discover prompt instead of the amount keypad) — a provisioning dependency like send_to_contact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two pre-existing Maestro flow failures on
code/cash(surfaced while running the full journey suite as a regression check; unrelated to the beta-flag removal).Give button label
The give nav button renders "Cash" (
GiveButtonLabel.Cash→action_cash), not "Give", sopull_out_bill.yaml'stapOn: Givenever matched. Now taps "Cash".Sheet dismissal
close_open_sheet.yamlswiped down once and asserted the scanner. But a destination opened inside a sheet (e.g. wallet → token info) is pushed onto that sheet's own nav stack, so one dismiss only pops a layer — leaving the wallet, not the scanner. It now presses Back until the scanner (the root behind the single open sheet) is revealed:repeat times: 5) so a stuck sheet can't hang CI.This fixes
open_token_info_deeplink.yaml, which also drops its final unasserted deeplink "reopen" — re-firing the same token deeplink is a no-op (the app dedupes it), so the step silently did nothing.Verified
open_token_info_deeplink→ passes (opens token info via deeplink, dismisses cleanly to the scanner).claim_cashlink/show_bill_and_put_back_in_wallet→ now tap Cash correctly, but still require an account with a giveable balance (the give flow otherwise shows a deposit/discover prompt instead of the amount keypad). That's a provisioning dependency likesend_to_contact— tracked separately, not a selector/flow bug.