CHG: Update XML tags of EnergyCalibration and DepthCalibration - #197
Open
fhagemann wants to merge 2 commits into
Open
CHG: Update XML tags of EnergyCalibration and DepthCalibration#197fhagemann wants to merge 2 commits into
EnergyCalibration and DepthCalibration#197fhagemann wants to merge 2 commits into
Conversation
Author
|
Feel free to approve / request changes, but I would propose to wait with merging this until #194 is approved, and then merge both PRs at the same time. |
ckierans
approved these changes
Aug 19, 2026
ckierans
left a comment
ckierans
left a comment
Collaborator
There was a problem hiding this comment.
I love the consistency :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #193:
The renaming of the TAC calibration module in #194 might require folks to update their nuclearizer configuration files, so I would suggest to also tackle updating the XML tags of
EnergyCalibrationandDepthCalibrationtoXmlTagEnergyCalibrationandXmlTagDepthCalibrationin the same run, so that the config files only have to be updated once.I also added a small note to the
CodingConventions.mdthat XML tags ofMModulesshould start withXmlTag.