refactor: split tools.rs into focused submodules - #4
Merged
Merged
Conversation
Break the 1348-line tools.rs monolith into a tools/ directory with focused files: - response.rs: ToolResponse struct - options.rs: GrepOptions, FindOptions, OutputMode - sinks.rs: grep-searcher Sink impls for each output mode - common.rs: shared walker construction, filtering, error capture, drain_capped() - grep.rs: grep() and the three mode functions (content/files/count) - find.rs: find() - cat.rs: cat() - mod.rs: public re-exports and test helpers Key improvements: - Public API unchanged: mod.rs re-exports grep/find/cat and their option/response types, so server.rs requires zero changes - Deduped: the identical ~20-line UTF-8 byte-cap drain loops are now common::drain_capped() - Tests colocated: grep tests in grep.rs, find tests in find.rs, etc. - No clippy warnings in tools/ (and fixed 4 pre-existing warnings in scope.rs) Verification: cargo build clean, all 42 tests pass, clippy --all-targets 0 warnings. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break the 1348-line tools.rs monolith into a tools/ directory with focused files:
Key improvements:
Verification: cargo build clean, all 42 tests pass, clippy --all-targets 0 warnings.