Skip to content

refactor: split tools.rs into focused submodules #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devfire merged 2 commits into from
Jun 19, 2026
Merged

refactor: split tools.rs into focused submodules #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72eeb60
refactor: split tools.rs into focused submodules
devfire Jun 19, 2026
17137f1
Merge branch 'main' into tools-split
devfire Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/scope.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ mod tests {
fn check_accepts_path_inside_root() -> TestResult {
let td = TempDir::new()?;
fs::write(td.path().join("a.txt"), "x")?;
let s = Scope::new(td.path().to_path_buf())?;
let s = Scope::new(td.path())?;
let canon = s.check(td.path().join("a.txt"))?;
assert!(canon.ends_with("a.txt"), "got {}", canon.display());
Ok(())
Expand All @@ -71,7 +71,7 @@ mod tests {
#[test]
fn check_rejects_path_outside_root() -> TestResult {
let td = TempDir::new()?;
let s = Scope::new(td.path().to_path_buf())?;
let s = Scope::new(td.path())?;
match s.check("/etc/passwd") {
Err(AppError::OutOfScope(_)) => Ok(()),
other => Err(format!("expected OutOfScope, got {:?}", other).into()),
Expand All @@ -89,7 +89,7 @@ mod tests {
let link = td.path().join("link.txt");
std::os::unix::fs::symlink(&target, &link)?;

let s = Scope::new(td.path().to_path_buf())?;
let s = Scope::new(td.path())?;
match s.check(&link) {
Err(AppError::OutOfScope(_)) => Ok(()),
other => Err(format!("expected OutOfScope, got {:?}", other).into()),
Expand All @@ -100,7 +100,7 @@ mod tests {
fn check_rejects_path_traversal() -> TestResult {
// Even ../.. style paths get canonicalized before the prefix check.
let td = TempDir::new()?;
let s = Scope::new(td.path().to_path_buf())?;
let s = Scope::new(td.path())?;
let traversal = td.path().join("..").join("..");
match s.check(&traversal) {
// canonicalize-resolves to a directory that is not under root.
Expand Down
Loading