Allow break face drift for same target block#120
Merged
Conversation
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows terrain break validation to accept small client/server face drift when the server-authoritative ray still hits the same target block.
Why
frevenengine/freven-engine#386 rapid LMB smoke showed one remaining rollback:
FaceMismatch;The rejected action still targeted the same block. The mismatch was only the voxel face reported by DDA, caused by small client/server interaction-origin drift around voxel edges.
For break actions, face is not the authoritative edit identity. Breaking clears the whole target block. The server must still validate that the authoritative ray hits the same target block, that the target is loaded/solid/breakable, and that reach/stream/sequence rules pass.
For place actions, face and hit/contact semantics remain strict because they determine support and placement position.
What changed
validate_breakno longer rejects solely because the client-sampled face or hit point differs from the server-authoritative trace.Boundaries
Validation
cargo +stable fmt --all -- --checkcargo +stable test --locked -p freven_block_api terrain_interactioncargo +stable test --locked --workspacecargo +stable clippy --locked --workspace --all-targets -- -D warningsgit --no-pager diff --checkRelated: