Skip to content

Consume the editor from npm, not from packages/ - #183

Merged
tosinamuda merged 1 commit into
mainfrom
chore/editor-from-npm
Aug 24, 2026
Merged

Consume the editor from npm, not from packages/#183
tosinamuda merged 1 commit into
mainfrom
chore/editor-from-npm

Conversation

@tosinamuda

Copy link
Copy Markdown
Contributor

The editor now lives in getlatentic/live-markdown and publishes itself. Compose depends on @latentic/live-markdown@^0.1.1 like any other consumer, and 20,462 lines leave this repository — history intact, all 115 commits carried across by git subtree split.

Why consuming it normally matters

The workspace arrangement resolved the package to its TypeScript source through a Vite alias and a matching tsconfig path. So Compose never once exercised the thing npm actually ships. That is how a broken declaration build sat unnoticed while every check here was green, and how the package's README came to promise that mathematics needs no CSS import — true of the source, false of the tarball.

Now the app builds against dist/, resolved through the package's own exports.

pnpm-workspace.yaml stays, with no members

Deleting it was worse than keeping it. pnpm then searches upward for a workspace to join, found the primary checkout's, and silently captured a git worktree nested under it — resolving the dependency back to packages/rich-editor in that checkout and reporting a successful install. The file now exists to stop the search, and says so.

Supersedes #182

Those two commits touched nothing outside the package, and are already released in 0.1.0. The fixes therefore arrive here through the registry instead:

  • a […] keeps its brackets until it resolves to a link
  • a table cell renders what the paragraph above it renders

Verified against the published tarball

Not against a symlink:

check result
pnpm typecheck clean
pnpm test 548 passing
pnpm build succeeds
shipped bundle contains the bracket fix confirmed

CI loses the editor-package build step

That gate has moved to the editor's own three-platform CI, where it belongs. Worth noting what happened the moment it ran anywhere but a Mac: it immediately found two bugs the macOS-only browser tier had been hiding — undo tests pressing Cmd literally where CodeMirror binds Ctrl, and a treeAt parse budget with seven milliseconds of headroom that let a delete cross a fence boundary. Neither was platform-specific. A single-platform test tier is a single-platform claim.

Release path

0.1.0 and 0.1.1 both published through tag-triggered CI using trusted publishing — no npm token exists anywhere, and provenance is attested automatically.

The editor now lives in getlatentic/live-markdown and publishes itself,
so Compose depends on `@latentic/live-markdown@^0.1.1` like any other
consumer. 20,462 lines leave this repository; the history came with them
via `git subtree split`, all 115 commits.

Consuming it the way everyone else does is the point. The workspace
arrangement resolved the package to its TypeScript SOURCE through a Vite
alias and a matching tsconfig path, so Compose never once exercised the
thing npm ships — which is how a broken declaration build sat unnoticed
while every check here was green, and how the package's own README came
to promise that mathematics needs no CSS import.

`pnpm-workspace.yaml` stays, with no members, because deleting it was
worse than keeping it: pnpm then searches UPWARD for a workspace to join,
and silently captured a git worktree nested under the primary checkout —
resolving the dependency back to that checkout's `packages/rich-editor`
and reporting success. The file now exists to stop the search.

Supersedes #182. Those two commits touched nothing outside the package
and are already released in 0.1.0, so the fixes arrive here through the
registry instead:

* a `[…]` keeps its brackets until it resolves to a link
* a table cell renders what the paragraph above it renders

Verified against the published tarball rather than a link: typecheck
clean, 548 tests passing, `pnpm build` succeeds, and the shipped bundle
really does contain the bracket fix.

The editor-package build step leaves CI with it. That gate has moved to
the editor's own three-platform CI, where it belongs — and where, given a
second platform for the first time, it immediately found two bugs the
macOS-only browser tier had been hiding.
@tosinamuda
tosinamuda merged commit 02991e3 into main Aug 24, 2026
3 checks passed
@tosinamuda
tosinamuda deleted the chore/editor-from-npm branch August 24, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant