fix: increase http client timeout#98
Merged
Merged
Conversation
ajbeattie
commented
Jun 17, 2026
Contributor
- Increases the global timeout for the http client, as posting a job for over 1000 deployments can easily take more than the 5 second default timer
- There is a small tradeoff here that a hung PostOne or Get call could now occupy a worker for the full 30 seconds, but the risk and downside of that are both pretty low in practice. We can optionally move to per-request timeouts later, but that's a bit more involved.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the HTTP client timeout used by the controller’s deploymentrecord API client to better support long-running requests (e.g., posting a cluster job when syncing large numbers of deployments).
Changes:
- Introduces a controller-level constant to define a 30-second timeout for the deployment record API client.
- Applies the new timeout by adding
deploymentrecord.WithTimeout(...)when constructing the API client.
Show a summary per file
| File | Description |
|---|---|
internal/controller/controller.go |
Adds and applies a 30s deployment record API client timeout during controller initialization. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
malancas
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.