Skip to content

fix: increase http client timeout #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajbeattie merged 1 commit into from
Jun 17, 2026
+6 −0
Merged

fix: increase http client timeout #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ const (
// informerSyncTimeoutDuration is the maximum duration of time allowed
// for the informers to sync to prevent the controller from hanging indefinitely.
informerSyncTimeoutDuration = 60 * time.Second

// deploymentRecordClientTimeoutSeconds sets the HTTP timeout for calls to the
// deployment record API. The timeout is generous to accommodate longer running
// calls like posting a cluster job.
deploymentRecordClientTimeoutSeconds = 30
)

type ttlCache interface {
Expand Down Expand Up @@ -133,6 +138,7 @@ func New(clientset kubernetes.Interface, metadataAggregator podMetadataAggregato
cfg.GHAppPrivateKeyPath,
))
}
clientOpts = append(clientOpts, deploymentrecord.WithTimeout(deploymentRecordClientTimeoutSeconds))

apiClient, err := deploymentrecord.NewClient(
cfg.BaseURL,
Expand Down