sysid: fix weights for selected and multidimensional sensors - #3474
Open
anxkhn wants to merge 1 commit into
Open
sysid: fix weights for selected and multidimensional sensors#3474anxkhn wants to merge 1 commit into
anxkhn wants to merge 1 commit into
Conversation
Author
|
hey @yuvaltassa, could you please review this pr when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply named sensor weights to every sensor component and resolve them against the actual observation layout.
The previous implementation zipped flattened component indices with one value per sensor, which failed for multidimensional sensors. It also used full
sensordataoffsets when residual observations contained a compact or reordered sensor subset.Weights are now assigned per sensor and use the measured signal mapping when available. Missing or non-sensor mapping entries raise a clear
ValueError.Tests