[newchem-cpp] Convert FrozenKeyIdxBiMap to class - #602
Open
mabruzzo wants to merge 41 commits into
Open
Conversation
All changes in this commit are a search-and-replace (plus some automated reformatting since the number of characters is changing)
This is inadvisable, but will be necessary to achieve reasonable performance in step_rate_newton_raphson
The default constructor now builds an instance holding 0 elements. The mk_invalid_FrozenKeyIdxBiMap function has beed converted to a private factory method
mabruzzo
force-pushed
the
ncc/FrozenKeyIdxBiMap-to-class
branch
from
August 16, 2026 13:24
8b89ddd to
390293d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #577 is merged
This is a relatively PR. It converts all of the functions associated with
FrozenKeyIdxBiMapinto methods. This makes the associated code less verbose. Importantly, the presence of constructors and destructors make it a lot easier to reason about the constructs built from this type.