Skip to content

fix(ci): remove orphaned ci-investigator governance test unblocking main - #1342

Merged
groupthinking merged 3 commits into
mainfrom
claude/determined-maxwell-zy9dl7
Aug 4, 2026
Merged

fix(ci): remove orphaned ci-investigator governance test unblocking main#1342
groupthinking merged 3 commits into
mainfrom
claude/determined-maxwell-zy9dl7

Conversation

@groupthinking

Copy link
Copy Markdown
Owner

Canonical issue

Closes # (no pre-existing issue; this documents a base-branch CI regression discovered by the PR-remediation routine — file/link one if governance requires it)

Outcome

Restores a green test job on main and on every open PR branched from it.

The eventrelay-ci-investigator GitHub Actions workflow and its compiled .lock.yml were intentionally deleted in 0a5c672 / 07b8a2e (2026-08-03 20:39, "remove EventRelay CI Investigator workflow — noise-only output; per repo cleanup"). The governance test test_ci_investigator_requires_dedicated_codex_credential was left behind and still read_text()s both deleted files, so it raises FileNotFoundError on every run built off main since that cleanup:

FAILED tests/unit/test_gh_aw_workflow_governance.py::test_ci_investigator_requires_dedicated_codex_credential
 - FileNotFoundError: '.github/workflows/eventrelay-ci-investigator.md'
= 1 failed, 7961 passed

This turned the required test check red on PRs #1216, #1336, #1338, #1341 (all built after the cleanup); #1285 predates it and stayed green.

Scope

  • Included: deletion of the single orphaned test function in tests/unit/test_gh_aw_workflow_governance.py.
  • Explicitly excluded: the dangling references to the deleted workflow in .github/workflows/gh-aw-validation.yml (lines 65/74/85) and .github/workflows/AUDIT.md. Cleaning those is a separate workflow-YAML change; the sibling test test_gh_aw_validation_pins_runtime_version currently asserts that name is still present, so touching it would widen scope. Flagged for follow-up.

Risk

  • Risk level: low
  • Failure mode: none — this removes a test that guards a file intentionally deleted per repo cleanup. No production code changes.
  • Rollback: revert this commit; CI returns to red.

Verification

Against head f5f52d2:

python3 -m pytest tests/unit/test_gh_aw_workflow_governance.py -q
8 passed in 0.12s

The full governance module is green; the sibling tests reference files that still exist (focused-coverage-controller.md, coverage.yml, ci.yml) and are unaffected.

  • Focused tests — tests/unit/test_gh_aw_workflow_governance.py (8 passed)
  • Required CI — pending on this PR's first run
  • Review threads resolved — n/a (new PR)

Production evidence

Not applicable — this changes a test-only file that guards deleted CI workflow definitions. No runtime, application, or deployed surface is touched.

Agent handoff

  • One canonical issue is linked — no pre-existing issue; base-branch regression documented above
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head — pending first run
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval — merge to protected main left for human approval

Agent provenance

Agent-authored by the PR-remediation routine.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VpUVACuBj4ahTsWC65CEe7


Generated by Claude Code

The `eventrelay-ci-investigator` GitHub Actions workflow and its compiled
`.lock.yml` were intentionally deleted in 0a5c672 / 07b8a2e ("remove
EventRelay CI Investigator workflow — noise-only output; per repo cleanup").
The governance test `test_ci_investigator_requires_dedicated_codex_credential`
was left behind and still reads both deleted files, so it raises
FileNotFoundError on every run built off main since that cleanup — turning the
required `test` job red on `main` and on every open PR branched from it.

Remove the orphaned test. The sibling governance tests reference files that
still exist (focused-coverage-controller.md, coverage.yml, ci.yml) and are
unaffected; the full governance module now passes (8 passed).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VpUVACuBj4ahTsWC65CEe7
@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v0-uvai Canceled Canceled Aug 4, 2026 5:58am

@github-actions github-actions Bot added the python label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • [‘architecture-gap’, ‘bug’, ‘ci-cd’, ‘ci/cd’, ‘copilot-rabbit’, ‘documentation’, ‘duplicate’, ‘enhancement’, ‘frontend’, ‘github_actions’, ‘good first issue’, ‘help wanted’, ‘high-priority’, ‘invalid’, ‘javascript’, ‘ml-model’, ‘needs-triage’, ‘pipeline-critical’, ‘placeholder-code’, ‘priority:high’, ‘python’, ‘python:uv’, ‘question’, ‘styling’, ‘tests’, ‘v0’]

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ce405a38-09b4-4f5b-acea-c03eba63d17a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA f3105f3.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Agent Completion Truth Gate: BLOCKED

Reasons: invalid_payload

Machine-readable verdict
{
  "details": {
    "collection_errors": [
      "incomplete_linked_issue_contract",
      "missing_linked_issue",
      "missing_closing_issue_reference",
      "missing_agent_run_id",
      "missing_agent_login"
    ],
    "invalid_fields": [
      "issue.number",
      "policy.agent_login",
      "policy.run_id"
    ]
  },
  "reasons": [
    "invalid_payload"
  ],
  "verdict": "blocked"
}

Workflow evidence

Copy link
Copy Markdown
Owner Author

Status / why the truth-gate is red

What this PR fixes: the required test job has been failing on main and on every PR branched after 0a5c672 / 07b8a2e (2026-08-03 20:39, "remove EventRelay CI Investigator workflow — per repo cleanup"). Those commits deleted .github/workflows/eventrelay-ci-investigator.md and its .lock.yml, but left test_ci_investigator_requires_dedicated_codex_credential, which still read_text()s both — so it raises FileNotFoundError:

FAILED tests/unit/test_gh_aw_workflow_governance.py::test_ci_investigator_requires_dedicated_codex_credential
= 1 failed, 7961 passed

Removing that single orphaned test is the whole change. Locally the governance module is green (8 passed); the sibling tests reference files that still exist and are untouched. Merging this restores test on main and unblocks the same failure on #1216, #1336, #1338, #1341.

On agent-completion/truth-gate (red — invalid_payload: issue.number, policy.agent_login, policy.run_id): this gate only evaluates because the fix landed on a claude/* branch (the branch-heuristic asymmetry tracked in #1286); the identical change on a fix//perf/ branch returns not_applicable (cf. #1285). Fully satisfying it would require minting a canonical issue and publishing agent-completion evidence events — I've left that governance sign-off to a human rather than auto-manufacture it. The code-level CI (test/build/lint/security/CodeQL) is the meaningful signal here.

Not auto-merging: merge to protected main is a human gate. This PR is staged and ready for your review + merge.


Generated by Claude Code

@linear-code

linear-code Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

GRV-294

…aw validation

The workflow's source .md and compiled .lock.yml were deleted in
0a5c672/07b8a2e, but gh-aw-validation.yml still compiled and diffed them,
and the governance test asserted the stale reference was present. Remove
the three dangling lines and flip the assertion to guard against
reintroduction.

Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
@groupthinking
groupthinking marked this pull request as ready for review August 4, 2026 05:54
Copilot AI balanced review requested due to automatic review settings August 4, 2026 05:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes stale governance references to the deleted CI investigator workflow, restoring CI validation.

Changes:

  • Deletes the orphaned credential test.
  • Removes the deleted workflow from gh-aw compilation and lock checks.
  • Updates the remaining governance assertion.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/unit/test_gh_aw_workflow_governance.py Removes obsolete tests and asserts the workflow stays excluded.
.github/workflows/gh-aw-validation.yml Stops validating nonexistent investigator files.

Comment thread .github/workflows/gh-aw-validation.yml
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 4, 2026
@groupthinking
groupthinking enabled auto-merge (squash) August 4, 2026 05:57
…well-zy9dl7

# Conflicts:
#	tests/unit/test_gh_aw_workflow_governance.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants