fix(ci): remove orphaned ci-investigator governance test unblocking main - #1342
Conversation
The `eventrelay-ci-investigator` GitHub Actions workflow and its compiled `.lock.yml` were intentionally deleted in 0a5c672 / 07b8a2e ("remove EventRelay CI Investigator workflow — noise-only output; per repo cleanup"). The governance test `test_ci_investigator_requires_dedicated_codex_credential` was left behind and still reads both deleted files, so it raises FileNotFoundError on every run built off main since that cleanup — turning the required `test` job red on `main` and on every open PR branched from it. Remove the orphaned test. The sibling governance tests reference files that still exist (focused-coverage-controller.md, coverage.yml, ci.yml) and are unaffected; the full governance module now passes (8 passed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VpUVACuBj4ahTsWC65CEe7
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Agent Completion Truth Gate: BLOCKEDReasons: Machine-readable verdict{
"details": {
"collection_errors": [
"incomplete_linked_issue_contract",
"missing_linked_issue",
"missing_closing_issue_reference",
"missing_agent_run_id",
"missing_agent_login"
],
"invalid_fields": [
"issue.number",
"policy.agent_login",
"policy.run_id"
]
},
"reasons": [
"invalid_payload"
],
"verdict": "blocked"
} |
Status / why the truth-gate is redWhat this PR fixes: the required Removing that single orphaned test is the whole change. Locally the governance module is green ( On Not auto-merging: merge to protected Generated by Claude Code |
…aw validation The workflow's source .md and compiled .lock.yml were deleted in 0a5c672/07b8a2e, but gh-aw-validation.yml still compiled and diffed them, and the governance test asserted the stale reference was present. Remove the three dangling lines and flip the assertion to guard against reintroduction. Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes stale governance references to the deleted CI investigator workflow, restoring CI validation.
Changes:
- Deletes the orphaned credential test.
- Removes the deleted workflow from gh-aw compilation and lock checks.
- Updates the remaining governance assertion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/unit/test_gh_aw_workflow_governance.py |
Removes obsolete tests and asserts the workflow stays excluded. |
.github/workflows/gh-aw-validation.yml |
Stops validating nonexistent investigator files. |
…well-zy9dl7 # Conflicts: # tests/unit/test_gh_aw_workflow_governance.py
Canonical issue
Closes # (no pre-existing issue; this documents a base-branch CI regression discovered by the PR-remediation routine — file/link one if governance requires it)
Outcome
Restores a green
testjob onmainand on every open PR branched from it.The
eventrelay-ci-investigatorGitHub Actions workflow and its compiled.lock.ymlwere intentionally deleted in0a5c672/07b8a2e(2026-08-03 20:39, "remove EventRelay CI Investigator workflow — noise-only output; per repo cleanup"). The governance testtest_ci_investigator_requires_dedicated_codex_credentialwas left behind and stillread_text()s both deleted files, so it raisesFileNotFoundErroron every run built offmainsince that cleanup:This turned the required
testcheck red on PRs #1216, #1336, #1338, #1341 (all built after the cleanup); #1285 predates it and stayed green.Scope
tests/unit/test_gh_aw_workflow_governance.py..github/workflows/gh-aw-validation.yml(lines 65/74/85) and.github/workflows/AUDIT.md. Cleaning those is a separate workflow-YAML change; the sibling testtest_gh_aw_validation_pins_runtime_versioncurrently asserts that name is still present, so touching it would widen scope. Flagged for follow-up.Risk
Verification
Against head
f5f52d2:The full governance module is green; the sibling tests reference files that still exist (
focused-coverage-controller.md,coverage.yml,ci.yml) and are unaffected.tests/unit/test_gh_aw_workflow_governance.py(8 passed)Production evidence
Not applicable — this changes a test-only file that guards deleted CI workflow definitions. No runtime, application, or deployed surface is touched.
Agent handoff
mainleft for human approvalAgent provenance
Agent-authored by the PR-remediation routine.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VpUVACuBj4ahTsWC65CEe7
Generated by Claude Code