fix(review): 收斂 3 個已合併 PR 的遺留 Codex 評論#435
Merged
Merged
Conversation
- i18n（PR 404）：canUseBrowserLanguageStorage 改為實際探測 localStorage 可寫， 私密模式/嵌入式瀏覽器切語言不再因 setItem 丟錯而失效 - worker（PR 414）：SPLIT_MEOW_HTML_PROFILE 補回 img-src https:，修復 legacy 遠端頭像被 CSP 擋； bump SECURITY_POLICY_VERSION 5.4→5.5 - smoke test（PR 415）：BASE_STATE 補 currency/krwPerTwd 重置，避免測試間幣別狀態洩漏 - 補 002 三筆 reward 條目（本次 +3，累計 +65） 測試：split-meow HomeAndHistorySmoke 17/17 通過、ratewise typecheck 通過、worker node --check 通過 Generated with Claude Code via Happy Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
- i18n localStorage 探測改用 finally 清除 probe key，可寫性結論僅依 setItem 避免 removeItem 丟錯時誤判為不可寫 - smoke test BASE_STATE 補 expenseCategory/settledPayments/catPlayMode 重置 防止未來測試設值後跨測試洩漏 - img-src https: 收窄列為 follow-up issue #437 - 補 002 reward 條目（本次 +1，累計 +66） 測試：ratewise typecheck 通過、split-meow HomeAndHistorySmoke 17/17 通過 Generated with Claude Code via Happy Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Contributor
Author
🤖 代理 Code Review 結論（Codex 配額用盡的替代方案）由於 Codex 配額用盡（ 結論：Approve — 無 CRITICAL / HIGH，三項改動生產級正確。已採納 2 項 hardening（commit
驗證：ratewise typecheck 通過、split-meow HomeAndHistorySmoke 17/17 通過、worker |
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
收斂 3 個已合併 PR（#404 / #414 / #415）中仍 unresolved 且未回覆的 Codex P2 評論。
變更
canUseBrowserLanguageStorage只查 window+非test，未實測 localStorage 可寫；私密模式/嵌入式瀏覽器切語言因setItem丟錯而失效setItem/removeItem實際探測；不可寫時 detection 回退['htmlTag','navigator']且caches:[]SPLIT_MEOW_HTML_PROFILE缺 fallback 的img-src https:，legacy 遠端頭像被 CSP 擋imgSources:['https:']；bumpSECURITY_POLICY_VERSION5.4→5.5BASE_STATE未重置currency/krwPerTwd，KRW 測試洩漏污染後續currency:'TWD'/currencyManuallySet:false/krwPerTwd:null/rateUpdatedAt:null驗證
HomeAndHistorySmoke17/17 通過node --check通過注意
wrangler deploy部署 security-headers Worker 才會生效於正式站。🤖 Generated with Claude Code