Implement N-gram indexer - #58
Draft
saki7 wants to merge 11 commits into
Draft
Conversation
saki7
force-pushed
the
implement-ngram
branch
2 times, most recently
from
August 11, 2026 19:51
01d8c0a to
e66263a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This kind of basic full-text search facility has recently been used in two of my own applications:
Following my personal rule that anything I end up implementing from scratch more than once across my own apps should be turned into a library, I'm submitting this to Iris.
This facility is well suited and is appropriate for Iris's scope because we don't generally want to import a gigantic text search framework in ordinary applications. Having this in Iris can potentially be an ideal choice for many use cases.
Note: due to the limited resources, I'm just submitting the implementation and unit tests without the documentation.