Skip to content

Fixed Git LFS pointers overwritten as plain Git blobs#5863

Merged
huidongc merged 4 commits into
isaac-sim:developfrom
huidongc:fix-lfs-pointers
May 29, 2026
Merged

Fixed Git LFS pointers overwritten as plain Git blobs#5863
huidongc merged 4 commits into
isaac-sim:developfrom
huidongc:fix-lfs-pointers

Conversation

@huidongc

Copy link
Copy Markdown
Collaborator

Description

Fixed an Git LFS issue introduced by #5522

git clone git@github.com:isaac-sim/IsaacLab.git --branch develop
Cloning into 'IsaacLab'...
remote: Enumerating objects: 266967, done.
remote: Counting objects: 100% (9465/9465), done.
remote: Compressing objects: 100% (1826/1826), done.
remote: Total 266967 (delta 9156), reused 7649 (delta 7636), pack-reused 257502 (from 5)
Receiving objects: 100% (266967/266967), 288.76 MiB | 3.18 MiB/s, done.
Resolving deltas: 100% (194599/194599), done.
Encountered 30 files that should have been pointers, but weren't:
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-albedo.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-depth.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-rgb.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-rgba.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-semantic_segmentation.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-simple_shading_constant_diffuse.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-simple_shading_diffuse_mdl.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-simple_shading_full_mdl.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-newton_renderer-depth.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-newton_renderer-rgb.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-newton_renderer-rgba.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-ovrtx_renderer-albedo.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-ovrtx_renderer-depth.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-ovrtx_renderer-rgb.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-ovrtx_renderer-rgba.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-ovrtx_renderer-semantic_segmentation.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-ovrtx_renderer-simple_shading_constant_diffuse.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-ovrtx_renderer-simple_shading_diffuse_mdl.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/newton-ovrtx_renderer-simple_shading_full_mdl.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-albedo.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-depth.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-rgb.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-rgba.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-semantic_segmentation.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-simple_shading_constant_diffuse.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-simple_shading_diffuse_mdl.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-simple_shading_full_mdl.png
        source/isaaclab_tasks/test/golden_images/shadow_hand/physx-newton_renderer-depth.png

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels May 29, 2026

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Isaac Lab Review Bot

Summary

This PR fixes 30 Git LFS pointer files that were incorrectly stored as raw binary content instead of LFS pointers.

Analysis

  • Type: Infrastructure fix (Git LFS)
  • Files changed: 30 PNG files in source/isaaclab_tasks/test/golden_images/shadow_hand/
  • Root cause: Issue introduced by PR #5522

Findings

All files are appropriate for LFS tracking - These are test golden images (PNG files) which should be tracked via Git LFS
No code changes - Only binary asset pointer fixes
Well-documented - PR description clearly lists the 30 affected files from the git clone warning message
Proper fix approach - Converts raw binary content back to proper LFS pointer format

Verdict

LGTM 👍 - This is a straightforward LFS pointer fix that resolves clone warnings. The fix is appropriate and the scope is correct.


Automated review by Isaac Lab Review Bot


Update (7840feb): Nice addition! The new pre-commit hook (check_git_lfs_pointers.sh) will prevent this class of issue from recurring. The hook is well-implemented with both incremental (per-file) and full-repo (git lfs fsck) modes. Still LGTM 👍

@huidongc huidongc requested review from kellyguo11 and nv-rgresia May 29, 2026 11:47
@huidongc huidongc changed the title Fixed Git LFS pointers Fixed Git LFS pointers overwritten as plain Git blobs May 29, 2026
@huidongc huidongc merged commit d7fd52f into isaac-sim:develop May 29, 2026
59 of 61 checks passed
@huidongc huidongc deleted the fix-lfs-pointers branch May 29, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants