Fixed Git LFS pointers overwritten as plain Git blobs#5863
Conversation
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot
Summary
This PR fixes 30 Git LFS pointer files that were incorrectly stored as raw binary content instead of LFS pointers.
Analysis
- Type: Infrastructure fix (Git LFS)
- Files changed: 30 PNG files in
source/isaaclab_tasks/test/golden_images/shadow_hand/ - Root cause: Issue introduced by PR #5522
Findings
✅ All files are appropriate for LFS tracking - These are test golden images (PNG files) which should be tracked via Git LFS
✅ No code changes - Only binary asset pointer fixes
✅ Well-documented - PR description clearly lists the 30 affected files from the git clone warning message
✅ Proper fix approach - Converts raw binary content back to proper LFS pointer format
Verdict
LGTM 👍 - This is a straightforward LFS pointer fix that resolves clone warnings. The fix is appropriate and the scope is correct.
Automated review by Isaac Lab Review Bot
Update (7840feb): Nice addition! The new pre-commit hook (check_git_lfs_pointers.sh) will prevent this class of issue from recurring. The hook is well-implemented with both incremental (per-file) and full-repo (git lfs fsck) modes. Still LGTM 👍
Description
Fixed an Git LFS issue introduced by #5522
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there