Skip to content
This repository was archived by the owner on Aug 16, 2024. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "hdwallet"
version = "0.4.1"
version = "0.4.2"
authors = ["jjy <jjyruby@gmail.com>"]
edition = "2021"
license = "MIT"
Expand All @@ -15,14 +15,14 @@ members = [
]

[dependencies]
secp256k1 = "0.26"
secp256k1 = "0.28.0"
rand_core = "0.6.4"
ring = "0.16"
ring = "0.17.5"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ring is only used for SHA-256 and HMAC. If instead the sha2 and hmac crates were used, the ring dependency could be dropped.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that this is precisely what the bip32 crate does, so perhaps users that don't want the ring dependency should use bip32 instead.

lazy_static = "1.4"
thiserror = "1.0.38"
thiserror = "1.0.50"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being bumped? is there a need to pin this crate to this new minimum version of thiserror?


[dev-dependencies]
hex = "0.4"
base58 = "0.1"
ripemd160 = "0.8"

@daira daira Feb 9, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to its crates.io entry, ripemd160 is deprecated and should be replaced with ripemd.

Suggested change
ripemd160 = "0.8"
ripemd = "0.1.3"

This will also need import changes.

rand = "0.8.3"
hex = "0.4.3"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being bumped? Is there a need to pin this crate to this specific minimum version of hex?

base58 = "0.2.0"
ripemd160 = "0.10.0"
rand = "0.8.5"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being bumped? Is there a need to pin this crate to this specific minimum version of rand?

2 changes: 1 addition & 1 deletion rust-toolchain
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.63.0
1.73.0