Update dependencies - #21
Conversation
The `ring` dependency update is particularly important, as that adds support for Windows ARM64 targeting. I also update the toolchain version. Finally, I bump the crate version to 0.4.2 to prepare for a release with the updated dependencies.
efa7719 to
33f2d4f
Compare
| [dev-dependencies] | ||
| hex = "0.4" | ||
| base58 = "0.1" | ||
| ripemd160 = "0.8" |
| secp256k1 = "0.28.0" | ||
| rand_core = "0.6.4" | ||
| ring = "0.16" | ||
| ring = "0.17.5" |
There was a problem hiding this comment.
ring is only used for SHA-256 and HMAC. If instead the sha2 and hmac crates were used, the ring dependency could be dropped.
There was a problem hiding this comment.
I note that this is precisely what the bip32 crate does, so perhaps users that don't want the ring dependency should use bip32 instead.
| ring = "0.17.5" | ||
| lazy_static = "1.4" | ||
| thiserror = "1.0.38" | ||
| thiserror = "1.0.50" |
There was a problem hiding this comment.
Why is this being bumped? is there a need to pin this crate to this new minimum version of thiserror?
| hex = "0.4.3" | ||
| base58 = "0.2.0" | ||
| ripemd160 = "0.10.0" | ||
| rand = "0.8.5" |
There was a problem hiding this comment.
Why is this being bumped? Is there a need to pin this crate to this specific minimum version of rand?
| base58 = "0.1" | ||
| ripemd160 = "0.8" | ||
| rand = "0.8.3" | ||
| hex = "0.4.3" |
There was a problem hiding this comment.
Why is this being bumped? Is there a need to pin this crate to this specific minimum version of hex?
|
I'm curious why this PR is suddenly getting all this attention -- from non-owners of the repo no less. This PR is as dead as ... 8 months old. I don't think jjyr will be merging this anyway. |
3 participants
The
ringdependency update is particularly important, as that adds support for Windows ARM64 targeting.I also update the toolchain version.
Finally, I bump the crate version to 0.4.2 to prepare for a release with the updated dependencies.