chore(deps): vscode-ext-kit 4.1.0, and editor.tabSize declared as read-only - #32
Merged
Conversation
…d-only `@kkdev92/vscode-ext-kit` `^4.0.0` → `^4.1.0`. `EditorSettings` declares `contributed: false`: the `editor.tabSize` group is a section this extension reads and does not own, and 4.1.0 lets the declaration say so, so the framework's manifest check stops asking package.json for it. The bundle grows by 6,415 bytes, all of it framework runtime 4.1.0 added and this extension links; `describePlan` and `diffManifest`, reached only through a test or the command line, are absent from it. The 4.0.1 tree-view fix rides along. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kkdev92/vscode-ext-kit^4.0.0→^4.1.0, andEditorSettingsdeclarescontributed: false.Why the flag
editor.tabSizebelongs to VS Code. This extension declares it so it can read it through the same typed accessor as its own settings — the declaration's comment has said so since it was written — but nothing in the declaration told the tooling, so the framework's manifest check treated the group like any other and askedpackage.jsonfor aneditor.tabSizeentry. 4.1.0 addscontributed: falsefor exactly this case. With it,npx vscode-ext-kit manifest dist/extension.jsreports:Before the flag, the same command reported that one setting as missing from the manifest.
The bundle grows by 6,415 bytes, and the growth is accounted for
Measured rather than asserted. The bundle was built against both kit versions and compared: 348,529 → 354,944 bytes.
KIT_VERSIONnow reads4.1.0, and the rest is framework runtime that 4.1.0 added and this extension links — a preflight failure reported as data rather than sentences, a shutdown timeout that names the hosted service, operations and scopes still holding it,inspect()on both scope kinds, anddefineExtensionrefusing a second activation afterdeactivate. What is reached only through a test or the command line stays out:describePlananddiffManifestdo not appear in the bundle.The 4.0.1 fix rides along: the tree-view adapter no longer disposes a module-declared provider twice on deactivation, which this extension's view was subject to.
No release is needed — the entry sits under
[Unreleased].Verification
Local, all exit 0:
lint,typecheck,check:l10n(225 messages), 236 unit + 35 integration tests,vsce package,verify:vsix, and the real Extension Host lane — 13 cases on VS Code 1.135.0.🤖 Generated with Claude Code