Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- `@kkdev92/vscode-ext-kit` `^4.0.0` → `^4.1.0`, and `EditorSettings` declares
`contributed: false`. The `editor.tabSize` group has always been a section
this extension reads and does not own; 4.1.0 lets the declaration say so, and
the framework's manifest check — now also a command, `vscode-ext-kit manifest`
— stops asking `package.json` for an `editor.tabSize` entry. Run against this
extension's bundle, it reports `manifest ok: 47 command(s), 10 setting(s),
3 view(s) agree`; before the flag it reported that one setting as missing.

**The bundle grows by 6,415 bytes (348,529 → 354,944), and the growth is
accounted for.** Built against both kit versions and compared: `KIT_VERSION`
now reads `4.1.0`, and the rest is framework runtime that 4.1.0 added and
this extension links — a preflight failure reported as data rather than
sentences, a shutdown timeout that names the hosted service, operations and
scopes still holding it, `inspect()` on both scope kinds, and
`defineExtension` refusing a second activation after `deactivate`. Nothing
reached through a test or the command line enters the bundle: `describePlan`
and `diffManifest` are absent from it, as they should be. The 4.0.1 fix rides
along as well — the tree-view adapter no longer disposes a module-declared
provider twice on deactivation, which this extension's view was subject to.

- `@kkdev92/vscode-ext-kit` `^3.0.0` → `^4.0.0`. The framework raised its own
`engines.vscode` to `^1.134.0`, which this extension already declares, so the
two now agree instead of the extension quietly requiring more than the library
Expand Down
11 changes: 7 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@
"clean": "rimraf dist coverage .vsix-verify-temp quick-utils.vsix"
},
"dependencies": {
"@kkdev92/vscode-ext-kit": "^4.0.0"
"@kkdev92/vscode-ext-kit": "^4.1.0"
},
"devDependencies": {
"@eslint/js": "^10.0.0",
Expand Down
5 changes: 5 additions & 0 deletions src/core/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,17 @@ export type Config = SettingsAccessor<ConfigValues>;
* declaration: a settings group is scoped to one section, and re-declaring a
* VS Code-owned setting under `quickUtils.*` would mean maintaining a second
* source of truth for something the editor already tracks.
*
* `contributed: false` says the same thing to the tooling: this extension reads
* the section and does not contribute it, so the manifest check does not ask
* `package.json` for an `editor.tabSize` entry.
*/
export const EditorSettings = defineSettings({
section: 'editor',
values: {
tabSize: setting.integer({ default: 4, minimum: 1, maximum: 16 }),
},
contributed: false,
});

/** What a feature is handed to read `editor.*`. */
Expand Down