Skip to content

feat(cinder-csi-plugin): add splitMode - #3067

Open
cwrau wants to merge 2 commits into
kubernetes:masterfrom
cwrau:feat/cinder-csi-plugin/add-split-mode
Open

feat(cinder-csi-plugin): add splitMode#3067
cwrau wants to merge 2 commits into
kubernetes:masterfrom
cwrau:feat/cinder-csi-plugin/add-split-mode

Conversation

@cwrau

@cwrau cwrau commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This allows the user to deploy the controller-manager split between the
management cluster and the workload cluster.

That way one can keep all openstack credentials out of the workload cluster.

Release note:

[cinder-csi-controller-manager] Allow deploying the controller-manager split between management and workload clusters.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 23, 2026
@k8s-ci-robot

k8s-ci-robot commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2026
@k8s-ci-robot

k8s-ci-robot commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Hi @cwrau. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2026
@cwrau
cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from aaeb1a0 to 81a7702 Compare January 23, 2026 16:50
@cwrau cwrau mentioned this pull request Jan 23, 2026
Open
@cwrau

cwrau commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Hello, anything I can do to help this getting reviewed?

@cwrau

cwrau commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Hello, is there something I can do to get this merged?

@cwrau
cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from 81a7702 to 708e56f Compare April 21, 2026 19:24
@k8s-triage-robot

k8s-triage-robot commented Jul 20, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@kubernetes-prow kubernetes-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2026
@cwrau

cwrau commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Still waiting for review...

@cwrau
cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from 708e56f to 0e667c6 Compare July 21, 2026 08:05
@kubernetes-prow

kubernetes-prow Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kayrus

kayrus commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2026
234u34k
234u34k suggested changes Jul 25, 2026
View reviewed changes

@234u34k 234u34k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking default-values regression; reproduction and requested test are documented inline.

Comment thread charts/cinder-csi-plugin/templates/controllerplugin-deployment.yaml Outdated
cwrau added 2 commits July 27, 2026 14:44
@cwrau
feat(cinder-csi-plugin): add splitMode
449a0d1 
This allows the user to deploy the controller-manager split between the
management cluster and the workload cluster.
@cwrau
chore: add ci test files
c52e1c9 
Signed-off-by: Chris Werner Rau <cwrau@cwrau.info>
@cwrau
cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from 0e667c6 to c52e1c9 Compare July 27, 2026 12:46
234u34k
234u34k approved these changes Jul 28, 2026
View reviewed changes

@234u34k 234u34k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on c52e1c93. The hostMount path is restored in both templates and the checks pass. This addresses my requested change, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kayrus kayrus Awaiting requested review from kayrus
@stephenfin stephenfin Awaiting requested review from stephenfin
1 more reviewer
@234u34k 234u34k 234u34k approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cwrau @k8s-ci-robot @k8s-triage-robot @kayrus @234u34k