Skip to content

release(v3): [3/4] Remove dead error handling code - #172

Merged
lasith-kg merged 1 commit into
mainfrom
release/v3-3-error-handling
Jul 14, 2026
Merged

release(v3): [3/4] Remove dead error handling code#172
lasith-kg merged 1 commit into
mainfrom
release/v3-3-error-handling

Conversation

@lasith-kg

@lasith-kg lasith-kg commented Jul 14, 2026

Copy link
Copy Markdown
Owner

📚 PR Train

This PR is part of a stacked PR train delivering the v3 release. Review/merge bottom-up in order:

# PR Change Base
1 #170 Modernize repository to actions/typescript (ESM + Node 24) main
2 #171 Add support for return_run_details release/v3-1-node-24
3 👉 #172 (this PR) Remove dead error handling code release/v3-2-dispatch-workflow
4 #173 v3 release (combined → main) main

⚠️ PRs 1–3 are stacked (each targets the one above). PR #173 is the combined branch that actually merges into main.


Removes redundant HTTP status-code guards that could never fire — Octokit already rejects on any status >= 400, so those checks were dead code.

Highlights

  • Removed unreachable status guards from repositoryDispatch, getWorkflowId, getWorkflowRuns, and getDefaultBranch.
  • Kept (and documented) the one meaningful guardworkflowDispatch still throws on a legacy 204 response to avoid silently returning undefined run details.
  • Tests updated to assert Octokit errors propagate rather than being swallowed.

No user-facing behavior change; failures now surface via Octokit's own (more descriptive) errors.

@lasith-kg
lasith-kg force-pushed the release/v3-3-error-handling branch from e29afdf to aaa8b86 Compare July 14, 2026 15:09
Base automatically changed from release/v3-2-dispatch-workflow to main July 14, 2026 15:13
@lasith-kg
lasith-kg merged commit 3979269 into main Jul 14, 2026
4 checks passed
@lasith-kg
lasith-kg deleted the release/v3-3-error-handling branch July 14, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant