release(v3): [3/4] Remove dead error handling code - #172
Merged
Conversation
This was referenced Jul 14, 2026
lasith-kg
force-pushed
the
release/v3-3-error-handling
branch
from
July 14, 2026 14:59
1312773 to
e29afdf
Compare
lasith-kg
force-pushed
the
release/v3-3-error-handling
branch
from
July 14, 2026 15:09
e29afdf to
aaa8b86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 PR Train
This PR is part of a stacked PR train delivering the v3 release. Review/merge bottom-up in order:
actions/typescript(ESM + Node 24)mainreturn_run_detailsrelease/v3-1-node-24release/v3-2-dispatch-workflowmain)mainRemoves redundant HTTP status-code guards that could never fire — Octokit already rejects on any status >= 400, so those checks were dead code.
Highlights
repositoryDispatch,getWorkflowId,getWorkflowRuns, andgetDefaultBranch.workflowDispatchstill throws on a legacy204response to avoid silently returning undefined run details.No user-facing behavior change; failures now surface via Octokit's own (more descriptive) errors.