fix: reject incompatible Apple runtime companions - #484
Merged
Conversation
Contributor
|
Chat app preview removed for |
leehack
marked this pull request as ready for review
September 7, 2026 18:40
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #483. Prerequisite for draft release #482; this corrective PR does not prepare or publish a release.
Reject resolved Apple llama.cpp companions whose framework pin does not match the core before emitting
LookupInProcess. Existing app constraintsllamadart: ^0.8.22with companion^0.0.17otherwise admit a v0.4.0 core patch while retaining v0.3.0 frameworks. This release-exposed defect was found before core0.8.23 publication; the name-only hook behavior predates the release-prep PR.Exact scope
Artifactsoverrides rather than treating a tag string as proof of their binary ABI. Core native runtime/source/backend overrides cannot bypass the check.yamldependency for real pubspec dependency parsing, covering flow syntax and nested keys. LiteRT-only, non-Apple and no-companion fallback behavior remain unchanged.Validation
bffa3a62325c530ca3aa34f222f34f7670e81f67cc31ed410a93df7c8f680bf8. Tests exercise the maintained manifest with this incompatible identity through the actual hook.High-risk regression review
93966bf0268e20b83eb3348297ad1e1eeb44b0f3, base9ed77aa12dbd6a6daef185a5bff7484b5a9a5f5f.unverifiedPrerequisites / externalPrerequisitesUnavailable: repository-local tooling cannot authenticate the dedicated App/auditor/protected environment/ruleset. This known owner-controlled governance boundary is not bypassed and no operational attestation is claimed. Evidence:/private/tmp/appleguard-readiness.json.No mark-ready, merge, tag, release, publication, workflow dispatch, settings or pin change was performed. Release#482 remains blocked until this prerequisite is reviewed and separately approved/merged, then integrated and requalified.