ORC: fill initial defaults for missing id-bound fields - #261
Closed
cbb330 wants to merge 1 commit into
Closed
Conversation
For the generic and id-bound ORC read path, omit an absent field that declares an initial-default from the projection and materialize it as a per-file constant through the reader. Present values and explicit nulls are preserved; id-less/name-mapped files keep legacy null synthesis. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 23, 2026
Collaborator
Author
|
Closing: this was based on the wrong branch ( Rebuilt as a clean 2-PR stack on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initial-defaultonly when it is absent from an id-bearing ORC file.idToConstant).Stack (bottom -> top)
1.2.x)chbush/orc-id-binding-backport)chbush/orc-column-default-api)chbush/orc-initial-default-orc-fill)Depends on #260. Review this PR's own delta against its base branch
chbush/orc-column-default-api(2 commits above appear until the lower PRs merge).Supported scope
Vectorized ORC and predicate pushdown on omitted default columns remain deferred.
Testing Done
iceberg-orcandiceberg-datasuites passTests generated with unit-tests plugin
Made with Cursor